882468 - Simplify BooleanGetPrimitiveValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Till Schneidereit [:till]]

Attachment: Simplify BooleanGetPrimitiveValue

This is even simpler than the version I gisted earlier, in that it makes the entire call path infallible.

Given how much simpler this is than what we currently have, I don't think the fact that we have to know about the input being a CCW matters too much.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 761763 [details] [diff] [review]
Simplify BooleanGetPrimitiveValue

Review of attachment 761763 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsbool.h
@@ +25,1 @@
>  BooleanGetPrimitiveValue(JSContext *cx, HandleObject obj, Value *vp);

Make this return the boolean value directly, rather than by outparam.  (And put the context at the end to indicate infallibility.)

Comment 3

[Till Schneidereit [:till]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f6babcfa00e

Comment 4

[Nicholas Nethercote [inactive]]

On my Linux box I get three regtest failures because of this:

  ecma_5/JSON/stringify-boxed-primitives.js
  ecma_5/JSON/stringify.js
  ecma_5/JSON/stringify-primitives.js

In all three cases the cause is the same:

  Assertion failure: wrappedBool->isCrossCompartmentWrapper(), at /home/njn/moz/mi8/js/src/jsbool.cpp:205

Comment 5

[Till Schneidereit [:till]]

Attachment: Fix bustage caused by simplifying BooleanGetPrimitiveValue.

How did I not see this?

Comment 6

[Tom S [:evilpie]]

Comment on attachment 764665 [details] [diff] [review]
Fix bustage caused by simplifying BooleanGetPrimitiveValue.

Review of attachment 764665 [details] [diff] [review]:
-----------------------------------------------------------------

:)

Comment 7

[Till Schneidereit [:till]]

So, this was actually backed out (https://hg.mozilla.org/integration/mozilla-inbound/rev/4703321564be), so I folded the two patches into one and relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03c829d7d4e7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03c829d7d4e7