Closed
Bug 882520
Opened 11 years ago
Closed 11 years ago
Two minor tweaks to the memory reporting paths.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
2.37 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
I found two minor inconsistencies in the memory reporting paths.
Assignee | ||
Comment 1•11 years ago
|
||
This patch: - Adds |0x| to the addresses given in some of the "zone(...)" paths. This is necessary for about:memory's diff mode to work -- it strips out 0x-prefixed addresses. And we already have the prefix in some "zone(...)" paths, I just forgot to add it in this one case. - Changes the non-GC lazy script path to use "lazy-script-data" instead of "lazy-scripts". This distinguishes it more clearly from "gc-heap/lazy-scripts" and makes it consistent with "script-data".
Attachment #761828 -
Flags: review?(bhackett1024)
Updated•11 years ago
|
Attachment #761828 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•11 years ago
|
||
I fixed a couple more "zone(%p)" instances in dom/workers/WorkerPrivate.cpp, too: https://hg.mozilla.org/integration/mozilla-inbound/rev/22c88d3d898a
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/22c88d3d898a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•