Two minor tweaks to the memory reporting paths.

RESOLVED FIXED in mozilla24

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I found two minor inconsistencies in the memory reporting paths.
(Assignee)

Comment 1

5 years ago
Created attachment 761828 [details] [diff] [review]
Two minor tweaks to the memory reporting paths.

This patch:

- Adds |0x| to the addresses given in some of the "zone(...)" paths.  This is
  necessary for about:memory's diff mode to work -- it strips out 0x-prefixed
  addresses.  And we already have the prefix in some "zone(...)" paths, I just
  forgot to add it in this one case.

- Changes the non-GC lazy script path to use "lazy-script-data" instead of
  "lazy-scripts".  This distinguishes it more clearly from
  "gc-heap/lazy-scripts" and makes it consistent with "script-data".
Attachment #761828 - Flags: review?(bhackett1024)
Attachment #761828 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 2

5 years ago
I fixed a couple more "zone(%p)" instances in dom/workers/WorkerPrivate.cpp, too:

https://hg.mozilla.org/integration/mozilla-inbound/rev/22c88d3d898a

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/22c88d3d898a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.