Should include URL if you can't delete a component




17 years ago
6 years ago


(Reporter: Stephen Rasku, Assigned: justdave)




(1 attachment)

815 bytes, patch
Jouni Heikniemi
: review-
Details | Diff | Splinter Review


17 years ago
If there are bugs outstanding on a component, it should include a URL you can
click on that will display those bugs.
Target Milestone: --- → Bugzilla 2.16
Priority: -- → P3

Comment 1

17 years ago
-> Bugzilla product, Administration component, reassigning.
Assignee: tara → justdave
Component: Bugzilla → Administration
Product: Webtools → Bugzilla
Version: Bugzilla 2.12 → 2.12
We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18


15 years ago
Attachment #128375 - Flags: review?


15 years ago
OS: Solaris → All
Hardware: Sun → All

Comment 4

15 years ago
Tested on the current CVS tip; applies correctly, has the expected result.

Comment 5

15 years ago
2 things:

1) I think you need to url_quote() the component, and

2) Would it be neater to have the number-of-bugs-text link to the buglist, like

"Sorry, there are <a href="xxx">$bugs</a> bugs..."

Comment 6

15 years ago
Comment on attachment 128375 [details] [diff] [review]

>     if ($bugs) {
>+        my $link = "<p>You can view these bugs <a href=\"buglist.cgi?component=$component\">here</a>.";
>         if (!Param("allowbugdeletion")) {
>             print "Sorry, there are $bugs bugs outstanding for this component. 
> You must reassign those bugs to another component before you can delete this
> one.";
>+            print $link;
>             PutTrailer($localtrailer);
>             exit;
>         }

1) GavinS' previous comments need to be addressed
2) Why use the temporary variable $link? If using it, declare it inside the
block where it's used (if !Param(...)).
3) The bug list link works unexpectedly if several products have a component
with the same name.
Attachment #128375 - Flags: review? → review-

Comment 7

15 years ago
Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20

Comment 8

14 years ago
This was fixed as part of the templatisation
Last Resolved: 14 years ago
Resolution: --- → WORKSFORME
Target Milestone: Bugzilla 2.20 → ---
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.