Closed
Bug 882601
Opened 12 years ago
Closed 12 years ago
document.l10n isn't available immediately
Categories
(L20n :: HTML Bindings, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: stas, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
|
5.16 KB,
patch
|
stas
:
review+
|
Details | Diff | Splinter Review |
Because we define document.l10n in loadResources, it is not immediately available when the bindings code runs. This makes it harder to add event listeners to it, or to use the Context::localize() method.
|
Reporter | |
Updated•12 years ago
|
Assignee: nobody → gandalf
Priority: -- → P1
Target Milestone: --- → 1.0
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #764172 -
Flags: review?(stas)
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 764172 [details] [diff] [review]
patch
Review of attachment 764172 [details] [diff] [review]:
-----------------------------------------------------------------
::: bindings/l20n/html.js
@@ +36,5 @@
> } else {
> var link = headNode.querySelector('link[rel="localization"]');
> if (link) {
> // XXX add errback
> + loadManifest(link.getAttribute('href')).then(ctx.freeze);
ctx.freeze.bind(ctx) just to be on the safe side?
Attachment #764172 -
Flags: review?(stas) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•