[ja, ja-JP-mac] Remove inactive searchplugins from mobile/searchplugins

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
google-jp.xml

I'm running some tests on searchplugins and this file is inside the mobile/searchplugins folder for both ja and ja-JP-mac but is unused (not in list.txt, you're currently using en-US google). 

Is there a specific reason for keeping it? If not, please remove this file and add a link to the changeset in this bug.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/0ef8d26fe225/mobile/searchplugins

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/file/d067ee5512dd/mobile/searchplugins
(Reporter)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Reporter)

Updated

5 years ago
Blocks: 882093
(Reporter)

Updated

5 years ago
Flags: needinfo?(nagato.kasaki)
Sorry, when we start fennec ja l10n we've talked about using specific version for ja locale but actually using global (en-US) one so far.

So, we can remove it now. (add it again if we'll use it)
Flags: needinfo?(nagato.kasaki)
(Reporter)

Comment 2

5 years ago
(In reply to dynamis (Tomoya ASAI) from comment #1)
> So, we can remove it now. (add it again if we'll use it)

You can go on and commit the change to your repository, please reference this bug in the commit message (e.g. "Bug 882618 - [ja, ja-JP-mac] Remove inactive searchplugin google-jp.xml from mobile/searchplugins"

Comment 3

5 years ago
Created attachment 785639 [details] [diff] [review]
remove google-jp.xml
Attachment #785639 - Flags: review?(l10n)
(Reporter)

Comment 5

5 years ago
Comment on attachment 785639 [details] [diff] [review]
remove google-jp.xml

Review of attachment 785639 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is good. When landing please refer to this bug in the commit message.

As said, a similar change must be applied to ja-JP-mac since there's the same problem.
Attachment #785639 - Flags: review?(l10n) → review+

Comment 6

5 years ago
(In reply to Francesco Lodolo [:flod] from comment #5)
Thank you for your review and comment.

I committed on ja and ja-JP-mac.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/1b30ab85a0df
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/bbf46a7c06d6
(Reporter)

Comment 7

5 years ago
Thanks, both commits look good :-)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.