Missing indication in required form fields

RESOLVED WORKSFORME

Status

Mozilla Reps
reps.mozilla.org
RESOLVED WORKSFORME
5 years ago
4 years ago

People

(Reporter: nemo, Assigned: Samiullah)

Tracking

Details

(Whiteboard: [mentor=giorgos@mozilla.com][difficulty=1/3][lang=html])

(Reporter)

Description

5 years ago
The following form fields have no indication to let user know that they are required for the form submission.

* Edit profile form
** Interests, Map marker

* Create/edit event
** Event venue map, Event category
(Reporter)

Updated

5 years ago
Group: mozilla-reps-admins

Comment 1

5 years ago
I would like to take this on. When I attempt to login using my local dev it always kicks me back to this - https://www.evernote.com/shard/s1/sh/1391aeb0-84ec-48ad-853c-0a77e47d9721/e19bfe287d245d21d6c194e0f90fb218 . I'm using my personal email (caseybecking@gmail.com) Should i try one of the others from the preloaded json file?

Comment 2

5 years ago
Also im getting this in the logs - 

[20/Aug/2013 19:54:50] "POST /browserid/mozilla/ HTTP/1.1" 302 0
[20/Aug/2013 19:54:50] "GET /login/failed/ HTTP/1.1" 302 0

Comment 3

5 years ago
My mistake forgot to set the SITE_URL

Comment 4

5 years ago
One thing we could do is something like this - https://www.evernote.com/shard/s1/sh/11a40d23-23f1-496b-9b05-16ac311278ff/0e0ac39ecb53d23e243a2eb9f5c58c75

I had to move the buttons from the right to the left since the buttons sat on top of the star. I also didn't want to just put some margin/padding in there since it doesn't look like much of the css is moving items around that way. Not sure if this is something the design team would need to look at to approve? Those stars a little funky because they have a top of -40px, so they actually sit above where they are placed as well. Let me know what you would like me to do.
(In reply to Casey Becking from comment #4)
> One thing we could do is something like this -
> https://www.evernote.com/shard/s1/sh/11a40d23-23f1-496b-9b05-16ac311278ff/
> 0e0ac39ecb53d23e243a2eb9f5c58c75
> 
> I had to move the buttons from the right to the left since the buttons sat
> on top of the star. I also didn't want to just put some margin/padding in
> there since it doesn't look like much of the css is moving items around that
> way. Not sure if this is something the design team would need to look at to
> approve? Those stars a little funky because they have a top of -40px, so
> they actually sit above where they are placed as well. Let me know what you
> would like me to do.

This looks great Casey! I think moving the buttons to the left works quite well. I can approve this as the product manager - no design review needed. Thanks :)

Comment 6

5 years ago
Pull request sent over - https://github.com/mozilla/remo/pull/464 . Not sure do I need to do anything else?
(Reporter)

Comment 7

5 years ago
Hi Casey, thanks for the pull request!

Some comments on that:

* In the required fields we are using an asterisk to indicate them.
* This pull request changes only the edit profile page. There are also some fields to be changed in the event edit page. I am listing them in the first comment.

Let's continue this discussion to github with inline comments to your updated pull request.
Assignee: nobody → caseybecking
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [kb=1099939]

Comment 8

5 years ago
Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/b71f72a26980dc495bafb8270908f55c03e2ac64
[fix bug 882676] Add missing indication in required form fields.

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Version: unspecified → 413
Stars to appear in all places listed in comment 1 but if the user ommit these we don't display error messages, or error messages are bellow the button (because button moved to the left to place the start on the right).

Casey, do you want to continue on this?
Status: RESOLVED → REOPENED
Flags: needinfo?(caseybecking)
Resolution: FIXED → ---

Comment 10

5 years ago
Yeah, ill keep working on it.
Flags: needinfo?(caseybecking)
I think 'Mark your interests' displays an error when left unchecked you can use the same code for 'Point yourself on map'. Likewise for events.

Thanks!
Version: 413 → unspecified
Casey any progress on that? If you're stuck you can always ping me on irc for help :)

Comment 13

4 years ago
Just getting back to this, will be working on it today. Sorry.
Thanks Casey! Let me know if you need any help to complete this.
Hey Casey, any updates on this? 

If you are pretty busy we can re-assign to another contributor and get you a new bug when you have more time.

Thanks!
Hi Casey,

I guess you're pretty busy at the time, but no worries. I'll de-assign you from this bug, so others can work on this and you 've got time again please come by #remo-dev to get you another.

Thanks for your contribution!
Assignee: caseybecking → nobody
Whiteboard: [kb=1099939] → [mentor=giorgos@mozilla.com][difficulty=1/3][lang=html]

Comment 17

4 years ago
Understood, Thank you.
(Assignee)

Comment 18

4 years ago
Hi there can I be assigned to this bug I have a substantial amount of HTML knowledge and how it works, can you reply asap. Thanks
Flags: needinfo?
Hi Samiullah,

Thanks for your interest in contributing to the ReMo portal. I am assigning this bug to you. If you need any help feel free to ping anyone at #remo-dev at irc. Documentation for setting up you irc client can be found here [1]. Documentation on how to setup your development environment for the ReMo portal can be found here [2].

[1] https://wiki.mozilla.org/IRC
[2] http://remo.readthedocs.org/en/latest/
Flags: needinfo?
Assignee: nobody → fjjdfsd
Hey Samiullah,

Are you making good progress on this bug? Do you need help to setup your environment or solve this issue?
Flags: needinfo?(fjjdfsd)
(Assignee)

Comment 21

4 years ago
So Far i've installed tortoiseHG and have made a repository then cloning the http://hg.mozilla.org/mozilla-central/respsotory. 

Alright so can you tell me where the but is located so I can work on it please.
Flags: needinfo?(fjjdfsd)
:samiullah, the reps code is not hosted in hg, it's hosted in github. Instructions for getting the code and setting up a local development environment are here:

http://remo.readthedocs.org/en/latest/installation-virtualenv.html
(Assignee)

Comment 23

4 years ago
Ok got the mozilla/remo cloned onto my desktop, you know the html document is it located in \GitHub\remo\remo\events\templates\ im checking the edit_event.html file and found the bug at line 423. Can you tell me where to look for the bug when you can please.
Hi Samiuallah,

You need to work on fixing that comment 9 reports. 

Please ping me (giorgos) on IRC for further instructions if you need to.
(Assignee)

Comment 25

4 years ago
can you tell me which IRC client to use and how to connect to you Giorgos please so I can get to assistance on the bug.
(Assignee)

Comment 26

4 years ago
Giorgos which server are you on the IRC plz
(Assignee)

Comment 27

4 years ago
Whats the IRC Channel name, so I can talk to you about the bug please
(Assignee)

Comment 28

4 years ago
Im Sami999 on IRC and I tried looking for giorgos on server Mozilla and IRCWorld IRC Network, but it cannot find your name. Can you tell me which channel and which server your connected to on the IRC please.
(Reporter)

Comment 29

4 years ago
Hi Samiullah,

Here [1] you can find information on how to connect to the irc server.
The channel we use for ReMo development is: #remo-dev

[1] https://wiki.mozilla.org/IRC
(Assignee)

Comment 30

4 years ago
which server
(Reporter)

Comment 31

4 years ago
The server is irc.mozilla.org
All the info you need to connect are in the previous link.
(Assignee)

Comment 32

4 years ago
im using mibbit, i've looked at the server but cant find irc.mozilla
(Assignee)

Comment 33

4 years ago
is it IRCWorld IRC Network, or irc-Hispano, IRC2.HU, IRC4Fun, IRCChat, IrcCity, IRCGate.it, IRCHighWay, iRCLiNE, IRCNET, IRCPlanet, IRCStorm, IRCWorld, irc|forex <- Which one
(Assignee)

Comment 34

4 years ago
Oh the is the Server selected supposed to be Mozilla and then type in for the channel #remo-dev
(Assignee)

Updated

4 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.