Closed
Bug 882688
Opened 11 years ago
Closed 11 years ago
you can attempt a save while not logged in and it shows an error
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
We used to have the button to save disabled if you were not logged in. We have broke this state. STR: 1. go to popcorn maker. 2. log out if already logged in. 3. make a change. 4. you should notice save goes from grey to green as soon as you make that change. 5. attempt to save your project. Expected: probably nothing, you shouldn't be able to click save. Actual: error thrown at you. Really, this is just a UX thing. We should make it easier for people to make and save something for the first time. They do not have an account and one of the first things they are going to see is an error.
Assignee | ||
Comment 1•11 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 2•11 years ago
|
||
I think I closed this too soon. It is still an issue.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → scott
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #768982 -
Flags: review?(schranz.m)
Comment 4•11 years ago
|
||
Comment on attachment 768982 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/81 R+
Attachment #768982 -
Flags: review?(schranz.m) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/bd95966f636d3950bb90f5ecd6171c6c30a5f407
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•