882712 - Point tooltool to tooltool virtualhosts

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Per bug 768879, we have virtualhosts set up that are dedicated to tooltool.  However, in production, tooltool is still looking at http://runtime-binaries.pvt.build.mozilla.org.

The two are serving files from the same directory, so they're identical, but moving to the vhosts will give us the ability to quickly re-host that service on other servers if load dictates.  It also eliminates some confusion in the web server configuration.

Given the code changes in bug 768123, this should just be a configuration change, adding

   http://tooltool.pvt.build.mozilla.org/build
   http://tooltool.pub.build.mozilla.org/try

or whatever folders you'd prefer to use (I guessed about try) to the configuration, and removing runtime-binaries.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Simone, I think you're planning to do this -- but I don't see you assigned.  Am I wrong?

Comment 2

[Simone Bruno [:simone]]

Hi Dustin, yes, this will be part of the landing of Bug 768123: once we make sure that the correct version of tooltool is used in all machines, we can use the two new servers replacing in all tooltool invocation the "runtime binaries" server with the appropriate one(s).

The landing of this is intertwined with the landing of all other changes applied to tooltool in the past months, so it is tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=920485 (which is assigned to me).

Comment 3

[Simone Bruno [:simone]]

I guess it makes sense to assign this to myself as well!

Comment 4

[Simone Bruno [:simone]]

Dustin: runtime-binaries.pvt.build.mozilla.org and tooltool.pvt.build.mozilla.org seem to be pointing to the same host, would you still want to replace all runtime-binaries references to tooltool.pvt.build.mozilla.org?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Yes, they're different virtualhosts, and runtime-binaries is not the correct choice.

Comment 6

[Chris Cooper [:coop] (he/him)]

Attachment: [buildbot-configs] Switch from runtime-binaries to tooltool

Comment 7

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8535787 [details] [diff] [review]
[buildbot-configs] Switch from runtime-binaries to tooltool

Review of attachment 8535787 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/db767bbeae20

Comment 8

[Chris Cooper [:coop] (he/him)]

There are also lots of examples of runtimes-binaries being used in mozharness. Should I fix those up too?

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

If they're being used for tooltool, yeah.

I think there are a few miscellaneous uses of runtime-binaries for non-tooltool purposes.  If so, those can stay.  If not, we'll kill the vhost.  We'll be able to tell from access logs.

Comment 10

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/db767bbeae20

Comment 11

[Chris Cooper [:coop] (he/him)]

Attachment: [mozharness] Switch from runtime-binaries to tooltool

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8537934 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool

Review of attachment 8537934 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not too familiar with mozharness, but the search-and-replace looks solid.

Comment 13

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8537934 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool

Review of attachment 8537934 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/mozharness/rev/f215541c63b6

Comment 14

[Pete Moore [:pmoore][:pete]]

In production: https://hg.mozilla.org/build/mozharness/rev/f215541c63b6

Comment 15

[Chris Cooper [:coop] (he/him)]

Missed a few things with the previous patch, mostly around proxxy. Follow-up patches coming shortly.

Comment 16

[Chris Cooper [:coop] (he/him)]

Attachment: [mozharness] Switch from runtime-binaries to tooltool for proxxy

Comment 17

[Chris Cooper [:coop] (he/him)]

Attachment: [puppet] Switch from runtime-binaries to tooltool for proxxy

Comment 18

[Chris Cooper [:coop] (he/him)]

Attachment: [mozilla-inbound] Switch from runtime-binaries to tooltool

This is the only example I can find in-tree of us calling runtime-binaries directly.

Comment 19

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8538524 [details] [diff] [review]
[puppet] Switch from runtime-binaries to tooltool for proxxy

Review of attachment 8538524 [details] [diff] [review]:
-----------------------------------------------------------------

Do you want to keep both of these entries in place during the transition?

Comment 20

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8538525 [details] [diff] [review]
[mozilla-inbound] Switch from runtime-binaries to tooltool

Review of attachment 8538525 [details] [diff] [review]:
-----------------------------------------------------------------

I don't even know what repo this is in, but hey, looks good :)

Comment 21

[Chris Cooper [:coop] (he/him)]

(In reply to Dustin J. Mitchell [:dustin] from comment #19)
> Do you want to keep both of these entries in place during the transition?

Yes. That's probably a good idea.

Comment 22

[Chris Cooper [:coop] (he/him)]

Attachment: [puppet] Switch from runtime-binaries to tooltool for proxxy, v2

Preserve runtime-binaries while we transition.

Comment 23

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8538525 [details] [diff] [review]
[mozilla-inbound] Switch from runtime-binaries to tooltool

Review of attachment 8538525 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/c772701d6d62

Comment 24

[Chris Cooper [:coop] (he/him)]

Comment on attachment 8538521 [details] [diff] [review]
[mozharness] Switch from runtime-binaries to tooltool for proxxy

Review of attachment 8538521 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/mozharness/rev/f05a3b9237d8

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c772701d6d62

Comment 26

[Dustin J. Mitchell [:dustin] (he/him)]

THANKS COOP! :)