Closed
Bug 882738
Opened 11 years ago
Closed 11 years ago
Remove SRCS_IN_OBJDIR from Makefile.in
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla24
People
(Reporter: mshal, Assigned: mshal)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
4.55 KB,
patch
|
joey
:
review+
|
Details | Diff | Splinter Review |
This variable still exists in several Makefile.in's, but is no longer used in rules.mk. From git logs it appears to have been removed in 2003.
|
||
Comment 1•11 years ago
|
||
Comm-central has a few cases: jcranmer@xochiquetzal /src/branch/mozilla-build $ find -name Makefile.in | grep -v mozilla | grep -v ldap/sdks | xargs grep SRCS_IN_OBJDIR ./mailnews/mapi/mapihook/src/Makefile.in:SRCS_IN_OBJDIR = 1 ./mailnews/mapi/mapihook/build/Makefile.in:SRCS_IN_OBJDIR = 1 ./calendar/libical/src/libical/Makefile.in:SRCS_IN_OBJDIR = 1
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #762161 -
Flags: review?(joey)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 762161 [details] [diff] [review] Bug 882738 - Remove SRCS_IN_OBJDIR from Makefile.in This review was quick.
Attachment #762161 -
Flags: review?(joey) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=d91b91b32e52 inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/436af1f4e151
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/436af1f4e151
Assignee: nobody → mshal
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•