882740 - the user is not able to reinstall an application

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Vikas Nanda]

Attachment: ezboot-http.log

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Firefox/21.0 (Beta/Release)
Build ID: 20130511120803

Steps to reproduce:

1. Uninstall a previously purchased application. 
2. Open the marketplace application. 
3. Search for the previously uninstalled application. 
4. Notice that the user is not able to install the application. 



Actual results:

The application failed to install once uninstalled.


Expected results:

The application should have installed.

Comment 1

[Vikas Nanda]

Attachment: reinstall application fails to install from my apps and when searching.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Can you provide an adb log (the HTTP requests aren't super helpful here) and/or an ashes report ID?

Comment 3

[Vikas Nanda]

Attachment: logcat log file

Comment 4

[Vikas Nanda]

Christopher, logcat file now added. Let me know if you need any further info.

Comment 5

[Vikas Nanda]

Attachment: logcatfile

Comment 6

[Vikas Nanda]

Attachment: Error message when trying to install application

Comment 7

[Christopher Van Wiemeersch [:cvan]]

I may have fixed this - can you please try reproducing against -dev?

Comment 8

[Vikas Nanda]

Attachment: screenshot

Comment 9

[Vikas Nanda]

Attachment: log cat

Comment 10

[Vikas Nanda]

(In reply to Christopher Van Wiemeersch [:cvan] from comment #7)
> I may have fixed this - can you please try reproducing against -dev?

I have tried again using MP dev but I am getting the same issue as before. I have uploaded a new log and screenshot if it helps. The application I tried for this log is pricetier5

Comment 11

[Kumar McMillan [:kumar]]

this is something we need to fix ASAP because you can get into this scenario if *anything* aborts the install process. In bug 890473 it looks like a manifest error in IQ funfit was causing an error in the install process and that led to the user being unable to install the app -- same 403 API error.

Comment 12

[Victor Carciu]

I encountered this problem on prod with Jaxogram app. Please see logs : id : 862c1

Comment 14

[Kumar McMillan [:kumar]]

FYI: because of bug 890473 we disabled IQ FunFit and Jaxogram and we set allow-paid-app-search to False. Let's undo that when this is fixed.

Comment 15

[michbier]

As 890473 has been flag as duplicate, I paste my info here again:

I am the developer of IQ FitFun and IQ FitFun Lite.

I also have a app "IQ FitFun Lite" on the App Market.
After "IQ FitFun" went live some days before, I got updates for "IQ FitFun Lite"?????
After download the APP did not start. After restart of Peak phone it worked again.

The only difference between the two apps is the name attribute of the manifest file

  "name": "IQ FitFun Lite",
  "name": "IQ FitFun",

This means the launch path for both apps is

  "launch_path": "/IQFitFun/index.html"

The only other difference of the two apps is one global parameter to switch between lite and full version.

On the market, the Manifest URL of "IQ FitFun" is empty, while "IQ FitFun Lite" is 

   https://marketplace.firefox.com/app/48acf911-8916-48d3-9d83-60fc37b2658b/manifest.webapp

The API URLs for both Apps are:

https://marketplace.firefox.com/api/v1/apps/app/iq-fitfun-lite/
https://marketplace.firefox.com/api/v1/apps/app/iq-fitfun/ 

The manifest files are not complex:

{
  "name": "IQ FitFunLite",
  "version": "1.2.6.1",

  "description": "Have fun with 43 free brain teasers for young and old (lite version).",
  "icons": {
     "16": "/IQFitFun/res/drawable/iqfitfun_lite_icon_round_16.png",
    "128": "/IQFitFun/res/drawable/iqfitfun_lite_icon_round_128.png"
  },
  "developer": {
    "name": "DsignMatters, Michael Biermann",
    "url": "http://sites.google.com/site/dsignmatters/"
  },
  "default_locale": "en",
  "launch_path": "/IQFitFun/index.html",
  "content_security_policy": "script-src 'self' 'unsafe-eval'; object-src 'self'",
  "installs_allowed_from": ["*"]
}

I hope this helps

Comment 16

[Andy McKay]

ttps://marketplace-dev.allizom.org/purchases. The payment flow will raise a 403 if the user has already purchased the app.

https://github.com/mozilla/zamboni/blob/master/apps/addons/decorators.py#L93

Fireplace shouldn't be calling start payment if the app has been bought. But presuming that code is already in place, I would assume this an issue with a fireplace or API cache being up to date.

Comment 17

[krupa raj[:krupa]]

Also, see bug 886626

Comment 18

[krupa raj[:krupa]]

Other related bugs: bug 882698, bug 882814

Comment 19

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/8c60205

This should fix all the problems. Let me know.

(In reply to krupa raj[:krupa] from comment #17)
> Also, see bug 886626

I'll let you dupe the other bugs.

(In reply to krupa raj[:krupa] from comment #18)
> Other related bugs: bug 882698, bug 882814

I'll let you dupe bug 882698 since it seems to solve it too. Bug 882814 I believe Basta has taken care of.

Comment 20

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/fireplace/commit/cf31f9e

Comment 22

[Vikas Nanda]

Attachment: log file

Comment 23

[Vikas Nanda]

Attachment: screenshot

Comment 24

[Vikas Nanda]

Issue still occurs, new screenshot and log added

Comment 25

[Kumar McMillan [:kumar]]

The screenshot you posted suggests that the actual device install failed not which might be a different issue. Can you attach a logcat? This will contain a JavaScript error or platform error explaining why the install failed.

I was able to reinstall an app just fine with these steps:
- delete IQ FitFun from my device
- log out
- log in with an account that had purchased the app
- navigate to My Apps
- install the app

Comment 26

[Vikas Nanda]

(In reply to Kumar McMillan [:kumar] from comment #25)
> The screenshot you posted suggests that the actual device install failed not
> which might be a different issue. Can you attach a logcat? This will contain
> a JavaScript error or platform error explaining why the install failed.
> 
> I was able to reinstall an app just fine with these steps:
> - delete IQ FitFun from my device
> - log out
> - log in with an account that had purchased the app
> - navigate to My Apps
> - install the app

Hi Kumar, This issue no longer occurs, thanks

Comment 27

[Victor Carciu]

Verified as fixed based on comment #26.