Closed
Bug 882744
Opened 11 years ago
Closed 11 years ago
(Australis) Widgets (re)moved to the palette keep the disabled state
Categories
(Firefox :: Menus, defect)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mikedeboer, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M?][Australis:P4])
Attachments
(1 file, 1 obsolete file)
|
3.58 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
When you drag a button from the toolbar or panel to the palette while it's disabled, the [disabled] attribute is not removed, thus keeping the disabled appearance.
|
||
Updated•11 years ago
|
Whiteboard: [Australis:M?] → [Australis:M?][Australis:P4]
|
Assignee | |
Comment 1•11 years ago
|
||
For bug 873398 we introduced a custom class for items in the panel. As far as I can tell, we have opacity rules for this on all platforms, and this more specific rule is breaking the behaviour of not showing items as being disabled if in customization mode. Also, it seems we don't remove this class correctly when moving items from the panel to the palette, for some reason, and it's doing extra work in buildArea which is in the hotspot for tspaint (see bug 880611). So, I thought it might make sense to just remove this.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #767908 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 3•11 years ago
|
||
qnew does sort of help...
Attachment #767908 -
Attachment is obsolete: true
Attachment #767908 -
Flags: review?(jaws)
Attachment #767938 -
Flags: review?(jaws)
|
||
Updated•11 years ago
|
Attachment #767938 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Pushed: https://hg.mozilla.org/projects/ux/rev/3f8f2599f055
Whiteboard: [Australis:M?][Australis:P4] → [Australis:M?][Australis:P4][fixed-in-ux]
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f8f2599f055
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M?][Australis:P4][fixed-in-ux] → [Australis:M?][Australis:P4]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•