88277 - (JA) PSM: Cut off strings in "Load PKCS#11 Module" dialog

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Andreas Becker]

Build: JA Win Beta1 build 20010607

Steps:
1. In Preferences select category "Privacy and Security/Certificates"
2. Click on "Manage Security Devices"
3. In "Device Manager" dialog click on Load
4. see Load PKCS#11 Device dialog is too small, it cuts off the strings and 
button

(See attachment)



------- Additional Comments From [e-mail] 2001-06-14 15:26:27 ----

Adding jaRTM keyword.



------- Additional Comments From [e-mail] 2001-06-14 15:27:06 ----

Created an attachment (id=1866)
JA "Load PKCS#11 Module" dialog




------- Additional Comments From [e-mail] 2001-06-28 10:14:03 ----

reassigning to rchen



------- Additional Comments From [e-mail] 2001-06-28 11:06:08 ----

Reassigned to javi.

Andreas, you probably need to move the bug to bugzilla.



------- Bug moved to this database by [e-mail] 2001-06-28 13:46 -------

This bug previously known as bug 6475 at http://bugscape.netscape.com/
http://bugscape.netscape.com/show_bug.cgi?id=6475
Originally filed under the Browser product and Localization-JA component.

---
Unknown bug field "attachment" encountered while moving bug
<attachment>
  <attachid> 1866 </attachid>
  <date> 06/14/01 15:27 </date>
  <desc> JA "Load PKCS#11 Module" dialog </desc>
</attachment>
Skipping unknown keyword: jaRTM.

Comment 1

[Javier Delgadillo]

re-assign to ssaux for triage

Comment 2

[Andreas Becker]

Attachment: JA "Load PKCS#11 Module" dialog

Comment 3

[Andreas Becker]

adding nsbeta1 keyword.

Comment 4

[Stephane Saux]

change to psm
The preference password setting dialog has been modified.  Can you test the 
latest 0.9.2 branch build to tell us whether the japanese version still has this 
problem?

Comment 5

[Andreas Becker]

We are awaiting a new Japanese build within the next few days.  Changing QA
contact to [e-mail].  Xianglan, can you retest this once we received the
new Japanese build?

Comment 6

[ji]

Checked the Japanese build based on 07/05 branch build, the problem is still there.

Comment 7

[Stephane Saux]

-> ddrinan

Comment 8

[tao]

If we can't make the dialog resize itself automatically, can we at least 
make it size localizable? In other word, explicitly assign width/height to the 
dialog window and externalize the width/height into *.dtd.

Also, making the dialog resizable migh be a quick workaround. 

Comment 9

[Ian McGreer]

The problem is at:

http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/content/device_manager.js#324

324 window.open("load_device.xul", "loaddevice", 
325 "chrome,width=300,height=200,resizable=0,dialog=1,modal=1");


Can you try removing the width and height attributes and see if it displays
correclty?

Comment 10

[tao]

Attachment: make dlg sizable; externalize wid/hei into property file

Comment 11

[tao]

Hi, David/McGreer:


Would you r/sr and then check it in for me? I don't have the permission to 
security module. thx.

Comment 12

[Ian McGreer]

r=mcgreer

Comment 13

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 14

[lchiang]

PDT+ per email to PDT.  Pls check into branch as soon as possible now that you 
have the r and sr.

Comment 15

[David P. Drinan]

Checked into the branch.

Comment 16

[Blake Ross]

David, does this bug remain open only to check the fix in to the trunk?

Comment 17

[rubydoo123]

Is this really checked in on the branch, or did you mean it was already in on
the trunk?  (It makes a big difference!)

Comment 18

[David P. Drinan]

It's checked into the branch. 

Comment 19

[David P. Drinan]

It's now checked into the trunk also.

Comment 20

[selmer (gone)]

Please close it fixed now :-)

Comment 21

[tao]

let me have the honor; just try to speed it up.

Comment 22

[ji]

Verified with the Ja build based on 07/17 branch build.
The dialog window is resizable now.  
But the default window size on Japanese build is too small. Will file a seperate
bugscape bug against Ja build.

Comment 23

[rchen]

We may be able to change the size. I will look into it.

Comment 24

[tao]

The size settings have been moved to pippki.properties.

Comment 25

[ckritzer (gone)]

On EN systems,

This is fixed on the Trunk for:
- Win98SE 2001-08-22-06-trunk (commercial)

But is still clipping the [Browse] button & Module Name text input field for:
- MacOS91 2001-08-22-08-trunk (commercial)
- MacOS_X 2001-08-22-05-trunk (mozilla)
- LinRH62 2001-08-22-08-trunk (commercial) (it chops the [Browse] button in half)

I'm tempted to re-open, but I'd like ji's input first.

Comment 26

[ji]

This dialog window is not resizable before the fix. Now the size is resizable 
and externalized to the property file, But the initial size is not big enough 
for English build on linux and mac system, the size is ajusted on Japanese 
builds though. I suggest a new bug be filed for the initial size problem on 
Linux and Mac.

Comment 27

[ji]

Marked it as verified. It's fixed.