Contacts API: Fix Date and pref properties

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

unspecified
mozilla24
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:-)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 attachment, 2 obsolete attachments)

instanceof doesn't handle cross-global objects.
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → anygregor
Posted patch patch (obsolete) — Splinter Review
Attachment #762147 - Attachment is obsolete: true
Attachment #762154 - Flags: review?(reuben.bmo)
Blocking leo+ bug.
blocking-b2g: --- → leo?
Posted patch patchSplinter Review
oh my
Attachment #762154 - Attachment is obsolete: true
Attachment #762154 - Flags: review?(reuben.bmo)
Summary: Contacts API: Fix Date properties → Contacts API: Fix Date and pref properties
Attachment #762169 - Flags: review?(reuben.bmo)
Comment on attachment 762169 [details] [diff] [review]
patch

Review of attachment 762169 [details] [diff] [review]:
-----------------------------------------------------------------

This is quite embarrassing :(
Thanks for the patch!
Attachment #762169 - Flags: review?(reuben.bmo) → review+
https://hg.mozilla.org/projects/birch/rev/c3fef5de1868


(In reply to Reuben Morais [:reuben] from comment #5)
> Comment on attachment 762169 [details] [diff] [review]
> patch
> 
> Review of attachment 762169 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This is quite embarrassing :(

Don't worry. Reviewers fault :)
Whiteboard: [fixed-in-birch]
Likely no longer a blocker since bug 879698 isn't a blocker currently.
https://hg.mozilla.org/mozilla-central/rev/c3fef5de1868
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Leo- for now as the user impact is unclear and neither is this blocking any other blocking bug.PLease renominate if there is a disagreement here.
blocking-b2g: leo? → -
You need to log in before you can comment on or make changes to this bug.