882799 - Gaia Music doesn't use radix parameter

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[tofumatt [:tofumatt]]

Although not likely to cause problems if only running on one platform (Gecko), we should always specify the radix when using a stock parseInt function for the sake of good coding practices. WebKit and Gecko, for instance, handle casting strings to numbers inside parseInt differently if the radix is not supplied.

I've submitted a patch for this.

Comment 1

[tofumatt [:tofumatt]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/8455

Pointer to Github pull-request

Comment 2

[Dominic Kuo [:dkuo]]

Hi tofumatt, thanks for contributing this. Actually the parseInt in utils.js is removed by the patch of bug 877313, so probably this is not an issue now. You can rebase your branch and after that you should found utils.js is already updated, thanks.

Comment 3

[Hubert Figuiere [:hub]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24105

Comment 4

[Hubert Figuiere [:hub]]

Changing title as there are a few places where we don't pass the radix, but the original one no longer.

Comment 5

[Dominic Kuo [:dkuo]]

Comment on attachment 8490093 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24105

Simple fix so looks good to me, thanks Hubert!

Comment 6

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/506da17d0f8dce5d1731b5fc48d5b64c52f55135