Closed Bug 882800 Opened 8 years ago Closed 8 years ago

[AccessFu] Use IndieUI inspired scroll request events

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 1 obsolete file)

Synthesizing keyboard events to a related slider widget was crazy.. IndieUI has a good path forward, we don't have to wait for it. We could use CusomEvent for now.
Attachment #762158 - Flags: review?(dbolter)
Comment on attachment 762158 [details] [diff] [review]
Use IndieUI inspired scroll requests.

Review of attachment 762158 [details] [diff] [review]:
-----------------------------------------------------------------

I assume there is a gaia piece to this that sets the uiactions attribute?

::: accessible/src/jsat/content-script.js
@@ +196,5 @@
> +          'scrollrequest', true, true,
> +          ObjectWrapper.wrap(details, elem.ownerDocument.defaultView));
> +        let unhandled = elem.dispatchEvent(evt);
> +        if (!unhandled)
> +          return;

Optional nit: The gecko in me wonders if this can just be
if (elem.dispatchEvent(evt) == 0)
  return;

Would that work?
Attachment #762158 - Flags: review?(dbolter) → review+
Good call. Carrying over r+
Attachment #762158 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4ee84aacb4de
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.