882800 - [AccessFu] Use IndieUI inspired scroll request events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Synthesizing keyboard events to a related slider widget was crazy.. IndieUI has a good path forward, we don't have to wait for it. We could use CusomEvent for now.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Use IndieUI inspired scroll requests.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 762158 [details] [diff] [review]
Use IndieUI inspired scroll requests.

Review of attachment 762158 [details] [diff] [review]:
-----------------------------------------------------------------

I assume there is a gaia piece to this that sets the uiactions attribute?

::: accessible/src/jsat/content-script.js
@@ +196,5 @@
> +          'scrollrequest', true, true,
> +          ObjectWrapper.wrap(details, elem.ownerDocument.defaultView));
> +        let unhandled = elem.dispatchEvent(evt);
> +        if (!unhandled)
> +          return;

Optional nit: The gecko in me wonders if this can just be
if (elem.dispatchEvent(evt) == 0)
  return;

Would that work?

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 882800 - Use IndieUI inspired scroll requests. r=davidb

Good call. Carrying over r+

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee84aacb4de

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ee84aacb4de