[AccessFu] Use IndieUI inspired scroll request events

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

({dev-doc-needed})

unspecified
mozilla24
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Synthesizing keyboard events to a related slider widget was crazy.. IndieUI has a good path forward, we don't have to wait for it. We could use CusomEvent for now.
(Assignee)

Comment 1

6 years ago
Created attachment 762158 [details] [diff] [review]
Use IndieUI inspired scroll requests.
Attachment #762158 - Flags: review?(dbolter)
Comment on attachment 762158 [details] [diff] [review]
Use IndieUI inspired scroll requests.

Review of attachment 762158 [details] [diff] [review]:
-----------------------------------------------------------------

I assume there is a gaia piece to this that sets the uiactions attribute?

::: accessible/src/jsat/content-script.js
@@ +196,5 @@
> +          'scrollrequest', true, true,
> +          ObjectWrapper.wrap(details, elem.ownerDocument.defaultView));
> +        let unhandled = elem.dispatchEvent(evt);
> +        if (!unhandled)
> +          return;

Optional nit: The gecko in me wonders if this can just be
if (elem.dispatchEvent(evt) == 0)
  return;

Would that work?
Attachment #762158 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 762354 [details] [diff] [review]
Bug 882800 - Use IndieUI inspired scroll requests. r=davidb

Good call. Carrying over r+
Attachment #762158 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4ee84aacb4de
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.