88284 - Active Accessibility: nsIAccessible interface should be made scriptable.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, enhancement, P3)

Description

[dsirnapalli]

All the interfaces under accessibility should be made scriptable.

Comment 1

[Aaron Leventhal]

Attachment: Patch v1.0

Comment 2

[Aaron Leventhal]

Attachment: Sample javascript to show scriptability of nsIAccessible

Comment 3

[Aaron Leventhal]

Okay, this works.

John, for your r=, notice I opted to make just one version of GetAccessibleFor,
that takes a DOM node, but doesn't take a pres shell. This simplified the code
in places.

I also got rid of the extra CoInitialize that we had in nsWindow.cpp. This extra
windows API call was slow and superfluous.

Comment 4

[John Gaunt (redfive)]

Looks good. Whitespace issues - adding lines between methods. Do it for all, or
not, doesn't matter to me just keep the file consistent. ( the standard seems to
be one line between ). 

  return (mAccService &&
+    NS_SUCCEEDED(mAccService->GetAccessibleFor(mDOMNode,
getter_AddRefs(mAccessible)))
+    && mAccessible);

This is just hard to read, put the '&&' in one place, end of line or beginning
of line

Why are you changing this comment? Alot more happens in that method

-// Deal with all sort of mouse event
+// Deal with accessible events

r= jgaunt with this issues resolved

Comment 5

[Aaron Leventhal]

Attachment: Patch v 1.1

Comment 6

[Aaron Leventhal]

Thanks, fixed the whitespace and the comment.
Someone had copy/pasted a method, changed it, and forgot to change the comment.
I've fixed the comment, correctly now, in this new patch.

Comment 7

[Brendan Eich [:brendan]]

Nits only, really:

+  /***********  Check if we need outer owning doc ************/


Extra space before "Check" above, and don't these C-style comments seem a bit
gaudy compared to the // C++ style one-liners elsewhere in the file?

This:

+  return (mAccService &&
+    NS_SUCCEEDED(mAccService->GetAccessibleFor(mDOMNode,
getter_AddRefs(mAccessible))) &&
+    mAccessible);

would be even prettier if the hanging indentation lined up:

+  return (mAccService &&
+          NS_SUCCEEDED(mAccService->GetAccessibleFor(mDOMNode,
getter_AddRefs(mAccessible))) &&
+          mAccessible);

Take 'em or leave 'em, no need for another patch if you do.  sr=[e-mail].

/be

Comment 8

[Aaron Leventhal]

fix checked in

Comment 9

[dsirnapalli]

-- Marking the bug as verified since all the accessibility interfaces are made
scriptable.