882895 - Geolocation: Assertion in GonkGPSGeolocationProvider::Handle

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Seems like we are expecting an object and getting a string:

[Parent 5471] WARNING: NS_ENSURE_TRUE(AttrToDataProp(attr, prop)) failed: file /Volumes/mac/moz/b2g18/content/html/content/src/nsDOMStringMap.cpp, line 166
/system/etc/*.cer: No such file or directory
clnt_call(532) 3000008c:00050000 call failed with an authentication error.

Program received signal SIGSEGV, Segmentation fault.
0x4142c03a in JSVAL_TO_OBJECT (this=0x498ce7c0, aName=<value optimized out>, aResult=...) at ../../../dist/include/jsapi.h:2205
2205	    JS_ASSERT(JSVAL_IS_OBJECT_OR_NULL_IMPL(JSVAL_TO_IMPL(v)));
(gdb) bt
#0  0x4142c03a in JSVAL_TO_OBJECT (this=0x498ce7c0, aName=<value optimized out>, aResult=...) at ../../../dist/include/jsapi.h:2205
#1  GonkGPSGeolocationProvider::Handle (this=0x498ce7c0, aName=<value optimized out>, aResult=...) at /Volumes/mac/moz/b2g18/dom/system/gonk/GonkGPSGeolocationProvider.cpp:685
#2  0x41a338ae in NS_InvokeByIndex_P (that=0x498ce7c8, methodIndex=3, paramCount=<value optimized out>, params=<value optimized out>)
    at /Volumes/mac/moz/b2g18/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:160
#3  0x41585d74 in CallMethodHelper::Invoke (this=0xbe81a498) at /Volumes/mac/moz/b2g18/js/xpconnect/src/XPCWrappedNative.cpp:3084
#4  CallMethodHelper::Call (this=0xbe81a498) at /Volumes/mac/moz/b2g18/js/xpconnect/src/XPCWrappedNative.cpp:2418
#5  0x41586fd0 in XPCWrappedNative::CallMethod (ccx=..., mode=<value optimized out>) at /Volumes/mac/moz/b2g18/js/xpconnect/src/XPCWrappedNative.cpp:2384
#6  0x4158e1ae in XPC_WN_CallMethod (cx=0x4037d3e0, argc=2, vp=<value optimized out>) at /Volumes/mac/moz/b2g18/js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1469
#7  0x41d41480 in js::CallJSNative (cx=0x4037d3e0, native=0x4158e0f9 <XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)>, args=...) at /Volumes/mac/moz/b2g18/js/src/jscntxtinlines.h:364
#8  0x41d556d0 in js::InvokeKernel (cx=0x4037d3e0, args=..., construct=js::NO_CONSTRUCT) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:367
#9  0x41d4ea3a in js::Interpret (cx=0x4037d3e0, entryFrame=<value optimized out>, interpMode=<value optimized out>) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:2475
#10 0x41d54f90 in js::RunScript (cx=0x4037d3e0, script=<value optimized out>, fp=0x43b81040) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:324
#11 0x41d55750 in js::InvokeKernel (cx=0x4037d3e0, args=..., construct=js::NO_CONSTRUCT) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:378
#12 0x41d04986 in Invoke (cx=<value optimized out>, argc=<value optimized out>, vp=<value optimized out>) at /Volumes/mac/moz/b2g18/js/src/jsinterp.h:109
#13 js::CallOrConstructBoundFunction (cx=<value optimized out>, argc=<value optimized out>, vp=<value optimized out>) at /Volumes/mac/moz/b2g18/js/src/jsfun.cpp:1095
#14 0x41d41480 in js::CallJSNative (cx=0x4037d3e0, native=0x41d046f5 <js::CallOrConstructBoundFunction(JSContext*, unsigned int, JS::Value*)>, args=...) at /Volumes/mac/moz/b2g18/js/src/jscntxtinlines.h:364
#15 0x41d556d0 in js::InvokeKernel (cx=0x4037d3e0, args=..., construct=js::NO_CONSTRUCT) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:367
#16 0x41d55f48 in Invoke (cx=0x4037d3e0, thisv=..., fval=..., argc=<value optimized out>, argv=0xbe81b130, rval=0xbe81b280) at /Volumes/mac/moz/b2g18/js/src/jsinterp.h:109
#17 js::Invoke (cx=0x4037d3e0, thisv=..., fval=..., argc=<value optimized out>, argv=0xbe81b130, rval=0xbe81b280) at /Volumes/mac/moz/b2g18/js/src/jsinterp.cpp:411
#18 0x41c94862 in JS_CallFunctionValue (cx=0x4037d3e0, objArg=0x49126740, fval=..., argc=1, argv=0xbe81b130, rval=0xbe81b280) at /Volumes/mac/moz/b2g18/js/src/jsapi.cpp:5895
#19 0x41581a76 in nsXPCWrappedJSClass::CallMethod (this=0x449b76d0, wrapper=<value optimized out>, methodIndex=<value optimized out>, info_=0x43912c38, nativeParams=0xbe81b368)

Comment 1

[Gregor Wagner [:gwagner]]

The setting in question is ril.supl.apn
Vicamo, should this be an object or a string?

Comment 2

[Kan-Ru Chen [:kanru] (UTC+9)]

It should be a string.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Yes, "ril.supl.apn", "ril.supl.user", "ril.supl.passwd" are all strings.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Gregor Wagner [:gwagner]]

b2g18 only. Bad things could happen if we get a null value and try to convert it to a string and get the compartment based on the object pointer.

Comment 6

[Wayne Chang [:wchang]]

Triage - leo+ based on comment 5

Comment 7

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/1bae70405481

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/1bae70405481