Closed Bug 882906 Opened 7 years ago Closed 7 years ago

remove EXTRA_DSO_LIBS

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla24

People

(Reporter: joey, Assigned: vlad)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 882907
Blocks: 882908
No longer depends on: 882904
Summary: move EXPORT_DSO_LIBS to moz.build → move EXTRA_DSO_LIBS to moz.build
EXTRA_DSO_LIBS is only used in a few places, and in most it's cut-and-paste worthlessness.

rules.mk expands EXTRA_DSO_LIBS to EXPAND_MOZLIBNAME,$(EXTRA_DSO_LIBS) -- but it's not referenced in any rules directly
Assignee: nobody → vladimir
No longer blocks: 870366
No longer blocks: 882907
Yep, we can just remove EXTRA_DSO_LDOPTS.  It's not referenced in any rules, and was always explicitly added to LIBS when it actually had an effect.  It only had an effect in one spot, where XUL was explicitly added right after anyway (for OSX).  In a bunch of places things were assigned to it, but it wasn't used anywhere and had no effect on the build.

Try results: https://tbpl.mozilla.org/?tree=Try&rev=f81fe94b1587
Attachment #762713 - Flags: review?(ted)
Attachment #762713 - Flags: review?(joey)
Comment on attachment 762713 [details] [diff] [review]
remove EXTRA_DSO_LIBS

Review of attachment 762713 [details] [diff] [review]:
-----------------------------------------------------------------

I totally just wrote this same patch. Awesome.
Attachment #762713 - Flags: review?(ted) → review+
Blocks: nomakefiles
No longer blocks: 882908
Comment on attachment 762713 [details] [diff] [review]
remove EXTRA_DSO_LIBS

cut & paste expansion and removal looks fine.

Was libxul needed while linking startupcache/test ?  xul was removed from there w/o replacement.
Attachment #762713 - Flags: review?(joey) → review+
Joey: note that EXTRA_DSO_LIBS wasn't actually functional--nothing in rules.mk ever put its value into the link line. This must have been removed a while back and nobody did the cleanup work that Vlad did here.
Summary: move EXTRA_DSO_LIBS to moz.build → remove EXTRA_DSO_LIBS
https://hg.mozilla.org/mozilla-central/rev/14d1a41e2129
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.