WiFi selection screen doesn't scroll properly

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: vladan, Assigned: mihai)

Tracking

unspecified

Firefox Tracking Flags

(blocking-b2g:-)

Details

Attachments

(2 attachments)

When scrolling the list of available WiFi networks during first-run, the horizontal rule near the top of the screen overlaps the list of available networks. 

Notice how the "Mozilla Guest" SSID is overlapped in the attached screenshot.
Assignee: nobody → mihai
Increase the top margin of the hotspot list wrapper to prevent the overlapping of the FTU progress bar with the WiFi networks.
Attachment #782908 - Flags: review?(fbsc)
Comment on attachment 782908 [details]
Pull Request #11239 - Don't overlap progress bar

Moving to fcampo review! ;)
Attachment #782908 - Flags: review?(fbsc) → review?(fernando.campo)
Requesting blocking-b2g:leo as this is reproducible on v1-train as well and it's bad user experience when scrolling the list of available WiFi networks.
blocking-b2g: --- → leo?
Minor polish issue :( but too late for 1.1 something that can land on master and get resolved in 1.2
blocking-b2g: leo? → -
Comment on attachment 782908 [details]
Pull Request #11239 - Don't overlap progress bar

Gosh, really sorry for forgetting about this, I focused on leo+ and this one slipped my mind.

Perfect patch, no risk on taking it, and helps users with a better view of wifi list.

Thanks Mihai, and sorry again for late review
Attachment #782908 - Flags: review?(fernando.campo) → review+
Thank you for checking the patch, Fernando! :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/f3c651847de0c7a032d959a6b67770e7a6a860f5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.