882909 - WiFi selection screen doesn't scroll properly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Vladan Djeric (:vladan)]

Attachment: SSID is overlapped by the horizontal rule

When scrolling the list of available WiFi networks during first-run, the horizontal rule near the top of the screen overlaps the list of available networks. 

Notice how the "Mozilla Guest" SSID is overlapped in the attached screenshot.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #11239 - Don't overlap progress bar

Increase the top margin of the hotspot list wrapper to prevent the overlapping of the FTU progress bar with the WiFi networks.

Comment 2

[Borja Salguero [:borjasalguero]]

Comment on attachment 782908 [details]
Pull Request #11239 - Don't overlap progress bar

Moving to fcampo review! ;)

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Requesting blocking-b2g:leo as this is reproducible on v1-train as well and it's bad user experience when scrolling the list of available WiFi networks.

Comment 4

[bhavana bajaj [:bajaj]]

Minor polish issue :( but too late for 1.1 something that can land on master and get resolved in 1.2

Comment 5

[Fernando Campo (:fcampo)]

Comment on attachment 782908 [details]
Pull Request #11239 - Don't overlap progress bar

Gosh, really sorry for forgetting about this, I focused on leo+ and this one slipped my mind.

Perfect patch, no risk on taking it, and helps users with a better view of wifi list.

Thanks Mihai, and sorry again for late review

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thank you for checking the patch, Fernando! :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/f3c651847de0c7a032d959a6b67770e7a6a860f5