882969 - Switch to GELF logging for graylog (loggins)

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[JP Schneider :jp]

Brian Brennan just worked through getting node.js logs much prettier and useful in our lovable graylog2 instance, loggins.  

Here is his pull request/compare for your reference.  
https://github.com/mozilla/openbadger/pull/229#issuecomment-19431672 / http://loggins.mofoprod.net:3000/messages/01af2b30-d477-11e2-ad76-22000aaa3d93

When this is going to go live, let me know so I can push out configs, etc.

Comment 1

[Chris DeCairos (:cade)]

I'm going to get started on this one today.

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/490

Adding humph for a review because this patch touches the cluster/domain error handling, replacing it with messina/bunyan logging.

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 830282 [details] [review]
https://github.com/mozilla/webmaker.org/pull/490

Would it make sense to replace our logging entirely with messina, instead of switching between express.logger and messina?

If not, there's some things to fix up. Let's discuss this tomorrow!

Comment 4

[Chris DeCairos (:cade)]

(In reply to Jon Buckley [:jbuck] from comment #3)
> Comment on attachment 830282 [details] [review]
> https://github.com/mozilla/webmaker.org/pull/490
> 
> Would it make sense to replace our logging entirely with messina, instead of
> switching between express.logger and messina?
> 
> If not, there's some things to fix up. Let's discuss this tomorrow!

The reason I use express.logger is because the logs with messina are in GELF format, so basically not human readable. The use of express.logger is recommended for localhost setups.

Comment 5

[Chris DeCairos (:cade)]

Comment on attachment 830282 [details] [review]
https://github.com/mozilla/webmaker.org/pull/490

Modified to work like we discussed - no logger.js file, simple check for using messina VS express.logger()

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/0a6c7b51d51d0d65b755fd1363465946918302d9
Bug 882969 - Use Messina and Bunyan for pretty GELF logs