Brian Brennan just worked through getting node.js logs much prettier and useful in our lovable graylog2 instance, loggins. Here is his pull request/compare for your reference. https://github.com/mozilla/openbadger/pull/229#issuecomment-19431672 / http://loggins.mofoprod.net:3000/messages/01af2b30-d477-11e2-ad76-22000aaa3d93 When this is going to go live, let me know so I can push out configs, etc.
I'm going to get started on this one today.
Assignee: jon → cade
Created attachment 830282 [details] [review] https://github.com/mozilla/webmaker.org/pull/490 Adding humph for a review because this patch touches the cluster/domain error handling, replacing it with messina/bunyan logging.
Attachment #830282 - Flags: review?(david.humphrey) → review+
Comment on attachment 830282 [details] [review] https://github.com/mozilla/webmaker.org/pull/490 Would it make sense to replace our logging entirely with messina, instead of switching between express.logger and messina? If not, there's some things to fix up. Let's discuss this tomorrow!
Attachment #830282 - Flags: review?(jon) → review-
(In reply to Jon Buckley [:jbuck] from comment #3) > Comment on attachment 830282 [details] [review] > https://github.com/mozilla/webmaker.org/pull/490 > > Would it make sense to replace our logging entirely with messina, instead of > switching between express.logger and messina? > > If not, there's some things to fix up. Let's discuss this tomorrow! The reason I use express.logger is because the logs with messina are in GELF format, so basically not human readable. The use of express.logger is recommended for localhost setups.
Comment on attachment 830282 [details] [review] https://github.com/mozilla/webmaker.org/pull/490 Modified to work like we discussed - no logger.js file, simple check for using messina VS express.logger()
Attachment #830282 - Flags: review- → review?(jon)
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/0a6c7b51d51d0d65b755fd1363465946918302d9 Bug 882969 - Use Messina and Bunyan for pretty GELF logs
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.