A source map's sourcesContent doesn't work when the original file path is absolute

RESOLVED FIXED in Firefox 24

Status

Product:
DevTools
Component:
Debugger
Type:
defect
Status:
RESOLVED FIXED
Opened:
6 years ago
Updated:
Last year

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

Version:
unspecified
Target:
Firefox 24
Platform:
x86
macOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

v1
15.55 KB, patch
dcamp
: review+
Details | Diff | Splinter Review 
Issue over in github: https://github.com/mozilla/source-map/issues/64

Pushed a fix to the mozilla/source-map library already, just need to import the latest build of that lib into our tree, and maybe add a test.
Assignee: nobody → nfitzgerald
Posted patch v1 — — Splinter Review 
https://tbpl.mozilla.org/?tree=Try&rev=dc67f2957799

* Updates to the latest mozilla/source-map library which has a fix for this bug, and a regression test

* Also adds another regression test to our debugger xpcshell tests
Attachment #762429 - Flags: review?(dcamp)
Comment on attachment 762429 [details] [diff] [review]
v1

Review of attachment 762429 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/sourcemap/SourceMap.jsm
@@ +1193,4 @@
>        var result = '';
>        var mapping;
>  
>        // The mappings must be guarenteed to be in sorted order before we start

'guaranteed', but that's not part of this patch.
Attachment #762429 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/d2567f054209
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 24
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.