882994 - [email] UI: Replace sync progress bar (including candy bar) / messages spinner with single spinning refresh button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

At the Madrid work week we (Casey Yee as UX point in conjunction with Josh Carpenter) settled on ditching the progress bar (including its candybar state) and the spinner we show at the bottom of the message list in favor of making the refresh icon spin.

This was primarily done for FPS and CPU utilization performance reasons.  However, by the end of the week we were being told performance was fine and got v1.1 push-back so I let the patch idle.

On bug 881583, Team Leo is reporting that our progress bar is (basically) confusing because it can trigger multiple times in sequence.  So I propose that we land the UI change since it provides more of a boolean indication that we are synchronizing and allows us to avoid creating a more complicated progress model.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

Pointer to Github pull-request

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 762988 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

Rob, it'd be great if you could take a look at the patch and/or sanity check that you are on board with what Casey and Josh had discussed with me in Madrid even if you can't directly review the patch.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

:robmac, ping.

Comment 4

[Wayne Chang [:wchang]]

In order to progress bug 881583, can we please have this landed if we do not hear back from UX by end of 6/25?

I will invalidate 881583 now so we have a better list for the week.

NI?UX also.

Comment 5

[Rob MacDonald [:robmac]]

Comment on attachment 762988 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

No luck on my device but I was able to view it in Aurora and it looks good. Thanks for keeping me posted on this. - Rob

Comment 6

[Stephany Wilkes]

Clearing this needinfo since Rob has addressed it.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 762988 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

(This is a small change that will also need to be propagated into the modularization refactor branch)

Comment 8

[James Burke [:jrburke]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

Pointer to Github pull-request

Comment 9

[James Burke [:jrburke]]

Comment on attachment 766096 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

Sorry, hit a wrong button, this is an invalid attachment, please disregard.

Comment 10

[James Burke [:jrburke]]

Commented in the pull request - just a question on the keyframe name and use, but once that is clarified, r=me.

Comment 11

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 762988 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10407

Review points addressed; landed.

Comment 12

[Andrew Sutherland [:asuth] (he/him)]

landed in gaia/master:
https://github.com/mozilla-b2g/gaia/pull/10407
https://github.com/mozilla-b2g/gaia/commit/9f283ab5e6b2e49513057138eacaa6adaff488ac

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 9f283ab5e6b2e49513057138eacaa6adaff488ac
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

manually uplifted to gaia/v1-train:
https://github.com/mozilla-b2g/gaia/pull/10595
https://github.com/mozilla-b2g/gaia/commit/60fc036792550c1d57faa917977b1113275fa476

:jhford, I'm assuming your magic robots will handle the v1.1hd uplift for me.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

beep boop beep boop 1.1hd: b6499bd17543910a1dad7afef5fd962672f8b572