Closed Bug 883081 Opened 12 years ago Closed 11 years ago

meta tagging not working from inside Thimble

Categories

(Webmaker Graveyard :: webmaker.org, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: laura, Assigned: thecount)

Details

Attachments

(1 file)

In my thimble page I have: <meta name="webmaker:thumbnail" content="http://hivenyc.org/images/thumbnails_webmaker/hackjam.jpg"> <meta name="webmaker:description" content="A Hack Jam is great for teaming up people with different skill-sets to explore an interesting challenge, collaboratively building something new or improving something that already exists, learning and teaching new hacking skills."> <meta name="webmaker:tags" content="guide"> <meta name="webmaker:tags" content="featured"> but the only thing that displays in the admin backend is the title and thumbnail. Description and tags have to be pasted directly into the backend.
hmm...tags printed this last make https://mozteach.makes.org/thimble/how-to-host-a-hive-popup. It just printed "guide,featured" but the webmaker: is needed for that to show up on /teach.
Unfortunatly, webmaker:description is actually just descriptions, example: <meta name="description" content="asdf"> This is because description is an actual meta tag recognized by more than just us, and not something we made ourselves. Anything with "webmaker:" is something we've made up. This is obviously not obvious, and we should fix it. Also, not yet sure why your tags are not being parsed but I'll look into it!
Assignee: nobody → scott
This should help reduce confusion as to webmaker: in thimble tags. If webmaker:description is used in a meta name, and it has because it makes complete sense to do this. Hopefully this helps.
Attachment #762685 - Flags: review?(pomax)
Attachment #762685 - Flags: review?(chris)
this looks sane to me, but chris should have a more authoritative opinion
Attachment #762685 - Flags: review?(pomax) → review+
Comment on attachment 762685 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/124 It's good, R+ lets make sure we communicate this tagging update to all the content folks.
Attachment #762685 - Flags: review?(chris) → review+
Attachment mime type: text/plain → text/x-github-pull-request
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: