88309 - xhtml:script element as :root element does not execute script

Status: RESOLVED FIXED

(Core :: XML, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

The reason is we have checks in several places that assume/check that a script
element must have a parent element. I think I have a fix.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix 1

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Vidur, you broke this with the dynamic script thing, so I think you should
review this. I don't know why the parent requirement was there; if you have a
reason let me know. The way we cause script execution feels a bit fragile and
unintuitive...

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix 2, retain parent check but also check doc root

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Vidur noted that with the first patch we can end up executing scripts twice. The
fix 2 should take care of that.

But I noticed additional problems. The contents of the script element are
visible, if it is the root element. Same is true for title element, and maybe
every "hidden" XHTML element if they are used as root elements. That seems kinda
weird...

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Oh well, I don't like how the fix looks like, and seeing that other XHTML
elements have problems working as root moving this to a later milestone.

I will try to get the cleanup work in another bug (unused variables etc.)

Comment 6

[Alex Vincent [:WeirdAl]]

This would be a very nice bug to fix for XML in general.  I treasure JavaScript
a great deal, but there's no XML tag specifically for scripting (and shouldn't be).

Would somebody be kind enough to put together a testcase, or give me a link to
one thereto?

Comment 7

[Alex Vincent [:WeirdAl]]

Incidentally, I came up with a workaround for this bug -- using a processing in
an XML document (which is itself encapsulated in an HTML iframe).  It's very
ugly, but it works...

Comment 8

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Uh, Alex, what are you talking about? This bug is about the script element from
the XHTML namespace not working as the root element of an XML document. It works
everywhere else.

So, this document does not work:

<script type="text/javascript" xmlns="http://www.w3.org/1999/xhtml">
  alert("Hello!");
</script>
But this, and any other document that has a non-script root element as well,
will work:

<doc>
  <script type="text/javascript" xmlns="http://www.w3.org/1999/xhtml">
    alert("Hello!");
  </script></doc>

Comment 9

[Alex Vincent [:WeirdAl]]

Oh, sorry about that!  *sheepish grin*

Comment 10

[Anne (:annevk)]

Attachment: test case

Right click is also disabled when the script element == root element. Will the
patch fix this or do I need to file a different bug?

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

File a different bug on that, but note the bugnumber here just in case...

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Fixed five years ago by bug 286000.