883091 - [Dialer] Autosuggestion is not working properly when a contact has two phone number with the same string

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[isabelrios]

Leo device with testrun3 build

Test case id: #7316

PROCEDURE
Create a contact with two phone numbers: A: 12345678 and 1234901
Open Dialer app and start typing: 1234

EXPECTED
The autosuggestion panel result should show two entries for the same contact, one for each number matching the string typped

ACTUAL
Only the first number for contact A is shown as a result of typing 1234.

Comment 1

[Dietrich Ayala (:dietrich)]

Gregor, do you know if this is front- or back-end?

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

So, I just tried, and it works for me on current master (see screenshot).

Can we know which gaia commit id was used in that build ?

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Aug 24)]

Attachment: screenshot

Comment 4

[Gregor Wagner [:gwagner]]

I assume the contact API returns the whole contact to the app. This needs a frontend fix.

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: screen shot

(In reply to Isabel Rios [:isabel_rios] from comment #0)
> Leo device with testrun3 build
> 
> Test case id: #7316
> 
> PROCEDURE
> Create a contact with two phone numbers: A: 12345678 and 1234901
> Open Dialer app and start typing: 1234
> 
> EXPECTED
> The autosuggestion panel result should show two entries for the same
> contact, one for each number matching the string typped
> 
> ACTUAL
> Only the first number for contact A is shown as a result of typing 1234.

Also works for me.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

To Rick and Julien,
What you reproduce is message app , but the actual issue is in dialer app which only show the first matching item of contact's tel information.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

Comment 8

[Etienne Segonzac (:etienne)]

Comment on attachment 763503 [details]
Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

Hi Rex,

I think you're the best reviewer for this patch :)

(feel free to ping me/ask for feedback? at any point if you have some doubts)

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 763503 [details]
Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

Hi George:
Most of them looks good for me, just a little concern on the _fillContacts(). I can r+ after the comment on Github are addressed.

Since there are changes on simplePhoneMatchers,
Etienne would you mind take a look on that?

Comment 10

[isabelrios]

(In reply to George Duan [:gduan] from comment #6)
> To Rick and Julien,
> What you reproduce is message app , but the actual issue is in dialer app
> which only show the first matching item of contact's tel information.

As George commented, the problem is seen from the dialer app.
It is still happening with today build, both v1-train (Gecko-2ff3151.Gaia-d8d189b)  and master (Gecko-2144715.Gaia-079b57f)
Thanks

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 763503 [details]
Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

Thanks for pining me, comments are on github.

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi Etienne,

Code updated , would you mind to take a look again? Thanks.

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 763503 [details]
Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

the simple phone matcher part looks good!

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 763503 [details]
Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10437

Looks good for me now.
Thanks for your work, George!

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master:
https://github.com/mozilla-b2g/gaia/commit/06ea38cdd5d4fd098ed37bfada64c91135c406ef

Oh, I didn't notice the comment before merging..
I think it's better to squash your commits (or add bug numbers to each commit) next time.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 06ea38cdd5d4fd098ed37bfada64c91135c406ef
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 17

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: Pointer to Github pull request https://github.com/mozilla-b2g/gaia/pull/10621

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: b9d51a3

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: b9d51a332bb68f705ad2d59614447f02f0441ed7
v1.1.0hd: 8e676640a18cc5c53c5d6dbffb582d671290fe80