883094 - Fix some test files that don't unset their prefs correctly

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Martijn Wargers (dead)]

Attachment: patch

This is based on what I found with the patch in bug 880178.

I'll get this on a try server.

Comment 1

[Martijn Wargers (dead)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=3a4d14a11bc8
Also included the patch from bug 880178.

Comment 2

[Martijn Wargers (dead)]

Note that this problem:
ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/crossorigin/test_video_crossorigin.html - start prefs different than end, difference:media.preload.auto,media.preload.default,diff
I didn't tackle, because this needs some more work in various files. I'll file a bug on that, once bug 868439 is fixed.

With the try server, I noticed a problem with the webspeech tests, where synthCleanup() is called multiple times by some test files, which is causing problems when the pref is removed in that function.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

Ok, I think this is ready for review.
There is still a pref leak with content/media/webspeech/synth/test/test_setup.html when it's run inside test_ipc.html (not really sure, why), I think/hope that would be fixed when this code would get converted to pushPrefEnv, eventually.
But I'm not going to try that now, because that would make this more complicated than it's worth for now.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 762773 [details] [diff] [review]
patch

Review of attachment 762773 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 5

[Martijn Wargers (dead)]

Attachment: patch for checkin

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1aa7e28ccaaf

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1aa7e28ccaaf