883118 - [homepage] follow up to homepage redo: remove unused code

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Axel Hecht [:Pike]]

In bug 864357, we removed the first_half/second_half display of locales, I forgot to notice that during the review.

I'll hack up a quick follow-up to remove the dead code.

Comment 1

[Axel Hecht [:Pike]]

Attachment: two patches, git log -p, let's see how that work. fixes tests

Doh, I totally forgot to verify tests when we did the redesign.

Those fail as they try to assert that we have the tabzilla assets locally. Which we don't. I switch off that test for assets that start with '//' in the first patch.

The second patch removes the un-used code to generate the two locale chunks for the homepage, as well as the test for it.

Tests run locally, and they pass now :-)

Comment 2

[Axel Hecht [:Pike]]

Bumping to P1, as we have broken tests right now.

Comment 3

[Jannis Leidel [:jezdez]]

Comment on attachment 762637 [details] [diff] [review]
two patches, git log -p, let's see how that work. fixes tests

Review of attachment 762637 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 4

[[github robot]]

Commits pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/8ec60d6f75f2fd40fd590b8cd3399ff77fc51a81
bug 883118, homepage follow up, fix tests, r=jezdez.
When adding tabzilla to elmo, we started including external assets via
//domain.org/foo. Exclude those from assets tests.

https://github.com/mozilla/elmo/commit/012ee2c33e5c0c4bd8d2d07bceeec158e789266c
bug 883118, remove unused code for the homepage that created two chunks of locales, r=jezdez