883124 - [Dialer] Airplane mode is disabled after calling to the emergency number

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Leo device, testrun3 build

Test case id: #8515

PROCEDURE
1. Enable Airplane mode
2. Go to Dialer and dial to an emergency number

EXPECTED
After the emergency call finished, the device is offline. If the SIM Card has pin enabled, then it should be required.

ACTUAL
After finishing the call the device goes back to online mode. The PIN is not requested. With no PIN, the behaviour is the same, device goes back to online mode.

Comment 1

[Beatriz Rodríguez [:brg]]

This is an blocker issue, the device should not go back into online mode before asking first for the PIN code.

Comment 2

[promise09th]

In android, airplane mode is disabled too (normal behavior)
But, device should request SIM pin.(if not, it is abnormal behavior)

Comment 3

[Alex Keybl [:akeybl]]

Over to David to reassign.

Comment 4

[Wayne Chang [:wchang]]

Can we have QA test this out with the PIN enabled on the SIM? I dont see how this is possible for the phone to go online without unlocking the PIN.

Comment 5

[Sarah Parsons]

On the Unagi 1.1 Build ID: 20130624070224 Airplane mode is disabled if the user makes an Emergency call with SIM PIN enabled however the data does not turn back on because the SIM is locked. 

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/62049a1c5d36
Gaia: 885b874029d8143035765ae903c147a9415fcc52
Platform Version: 18.1

On the Inari 1.0.1 Build ID: 20130624070215 The user cannot make any call with Airplane mode enabled with SIM PIN ON. An error message appears prompting the user to turn Airplane mode OFF before making a call. I've attached a screenshot of the error.

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 93241eb6c5d6c110710fad8da3ccd4423312b0c9
Platform Version: 18.0

Comment 6

[Sarah Parsons]

Attachment: Error

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Isabel Rios [:isabel_rios] from comment #0)
> Leo device, testrun3 build
> 
> Test case id: #8515
> 
> PROCEDURE
> 1. Enable Airplane mode
> 2. Go to Dialer and dial to an emergency number
> 
> EXPECTED
> After the emergency call finished, the device is offline. If the SIM Card
> has pin enabled, then it should be required.

If the device is offline after the call, the SIM PIN _shouldn't_ be requested right?

Comment 8

[isabelrios]

(In reply to Etienne Segonzac (:etienne) from comment #7)
> (In reply to Isabel Rios [:isabel_rios] from comment #0)
> > Leo device, testrun3 build
> > 
> > Test case id: #8515
> > 
> > PROCEDURE
> > 1. Enable Airplane mode
> > 2. Go to Dialer and dial to an emergency number
> > 
> > EXPECTED
> > After the emergency call finished, the device is offline. If the SIM Card
> > has pin enabled, then it should be required.
> 
> If the device is offline after the call, the SIM PIN _shouldn't_ be
> requested right?

Right if the device continues offline. Do not know exactly how the flow has been defined, but when trying to use the dialer or going back to online mode the PIN should be requiered

Comment 9

[Etienne Segonzac (:etienne)]

Looks like gecko isn't turning the airplane mode back on at the end of the emergency call.

Can we do this?

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Etienne Segonzac (:etienne) from comment #9)
> Looks like gecko isn't turning the airplane mode back on at the end of the
> emergency call.
> 
> Can we do this?

No, gecko doesn't turn the airplane mode back after the emergency call as Bug 849185 seems not request this behaviour. Hmmm, gecko can do this, but IMO this is very dependent on the user scenario a phone wants to provide (e.g. An Android phone on hand isn't turning the mode back). I don't really think ril backend should take care of this.

Comment 11

[Etienne Segonzac (:etienne)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> I don't really
> think ril backend should take care of this.

Thanks for the feedback!

If we stay online (like android does apparently) but fix the SIM PIN prompt issue would this fix the bug?

Comment 12

[Beatriz Rodríguez [:brg]]

(In reply to Etienne Segonzac (:etienne) from comment #11)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> > I don't really
> > think ril backend should take care of this.
> 
> Thanks for the feedback!
> 
> If we stay online (like android does apparently) but fix the SIM PIN prompt
> issue would this fix the bug?

The issue in this bug is that if the device is in airplane mode and it goes back online it should ask for the PIN code if it is enabled.

Comment 13

[Etienne Segonzac (:etienne)]

(In reply to Beatriz Rodríguez [:brg] from comment #12)
> The issue in this bug is that if the device is in airplane mode and it goes
> back online it should ask for the PIN code if it is enabled.

Got it, on it.

Comment 14

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR

Simple review :)

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 768153 [details]
Pointer to gaia PR

Basically good, but how about check the telephony/sms permission of current displayed app under attention screen before showing SIM PIN lock dialog?

For sure this needs some additional 'if else if else'.
And if we want this, consider to reuse https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/sim_lock.js#L55

Comment 16

[Etienne Segonzac (:etienne)]

added the comment as discussed on github.

Comment 17

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/979277a4b22996c95d228390a6803259f84cb182

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

More accurately as my understanding:
Because dial emergency call would turn off airplane mode automatically (in gecko),
so after the emergency call is ended, only the thing to block the user to receive the call is the SIM PIN dialog. We put the dialog back to the user then he could make choice: to unlock SIM PIN right away or delay it to afterwards, like what we do when lock-screen is unlocked.

Comment 19

[Gareth Aye [:gaye] (back from PTO)]

Uplifted 979277a4b22996c95d228390a6803259f84cb182 to:
v1-train: bf047115882e7e57cb3303857420091c80dbe303

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: bf047115882e7e57cb3303857420091c80dbe303