883130 - make legacy db less of a dependency

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

right now thimble can be run with or withour legacy db, but the former only if the legacy_db_* variables have not been set. If we change the codepath to pick db_* vars when legacy_db_* doesn't exist -or- it has no meaningful values, it'll be more robust.

Comment 1

[Jon Buckley [:jbuck]]

Suggestion: Have the LEGACY_DB become a boolean piggyback off of the existing DB info

Comment 2

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/135

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 763653 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/135

Error :(

/home/scott/ThimbleOnNode/lib/database.js:22
      options[key] = options[key] || fallback[key];
                            ^
TypeError: Cannot read property 'dbus_session_bus_address' of undefined
    at /home/scott/ThimbleOnNode/lib/database.js:22:29
    at Array.forEach (native)
    at databaseHandleConstructor (/home/scott/ThimbleOnNode/lib/database.js:21:27)
    at Object.<anonymous> (/home/scott/ThimbleOnNode/app.js:39:25)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)

Do you get this too?

Comment 4

[Pomax]

this looks like no options were passed to the DB at all, i.e. you had no DB_... variables in your .env

Comment 5

[Pomax]

Comment on attachment 763653 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/135

.env needs at least a DB_... variables block (should work, adding LEGACY_DB_... vars should be used if specified, with DB_... as fallback)

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 763653 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/135

Seems to happen with not legecy db variables.

Comment 7

[Pomax]

Comment on attachment 763653 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/135

fixed. Added a {} options object for when options isn't passed (meaning there were no legacy variables)

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/3929d4e00de3e68fcb520a9bca27306671c23a52
Merge pull request #135 from Pomax/bug883130

added a fallback arg for database option instantiation