883131 - [Call log] When there is one entry in Missed call and it is deleted, the time label is not removed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Leo device, testrun3 build

PROCEDURE
1. On DuT receive an incoming call, do not take it. (this should be the only missed call)
2. Go to Dialer and open the Call Log
3. Tap on Missed tab
4. Tap on Edit and select the missed call
5. Tap on Delete

EXPECTED
The entry is removed, the call log is empty

ACTUAL
The label of the day when the missed call was received is not removed.
It will dissapear when closing/opening the app

Comment 1

[isabelrios]

Attachment: Today label does not dissapear

Comment 2

[Sarah Parsons]

This issue reproduces on the Leo Build ID: 20130625070217

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia: 1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Platform Version: 18.1

When deleting a missed call from the log, the "Today" label is not removed.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Hi Mihai, I think it would be great to have feedback from Ayman or someone from UX regarding the expected behavior since as you will see in the code right now what we do is to show or hide the entries according to the selected filter. In my opinion there are 3 cases to consider here:
1.- The missed call is the last call inside a day header but not the last missed call in the Call Log. I guess in that case what we would want is the concrete day header to be hidden.
2.- The missed call is the last call inside a day header and the last missed call in the Call Log but not the latest entry in the Call Log (there are some incoming-connected or outgoing calls still in the Call Log). Should in this case the "No calls recorded. Start communicating now" be shown when the "Missed" tab is selected?
3.- The missed call is the last call inside a day header. It is the last missed call in the Call Log and also the latest entry in the Call Log. In this case and according to the current implementation, we show the "No calls recorded. Start communicating now" screen in the "Missed" and "All" tabs.
Thanks!

Comment 4

[ayman maat :maat]

(In reply to gtorodelvalle from comment #3)
> Hi Mihai, I think it would be great to have feedback from Ayman or someone
> from UX regarding the expected behavior since as you will see in the code
> right now what we do is to show or hide the entries according to the
> selected filter. In my opinion there are 3 cases to consider here:
> 1.- The missed call is the last call inside a day header but not the last
> missed call in the Call Log. I guess in that case what we would want is the
> concrete day header to be hidden.

remove (or hide) the day header if there are no calls within the call log (under either the 'all' or 'missed calls' tabs) for that particular day. We do not want any days displayed in the call log that do not have any calls associated to them. 

> 2.- The missed call is the last call inside a day header and the last missed
> call in the Call Log but not the latest entry in the Call Log (there are
> some incoming-connected or outgoing calls still in the Call Log). Should in
> this case the "No calls recorded. Start communicating now" be shown when the
> "Missed" tab is selected?

it would be preferable to do one of two things: 

2.1) if we are going to maintain visibility of the 'missed call' we need a more appropriate message under the 'missed call tab' than "No calls recorded. Start communicating now" (missed calls are not an action of the user, they are an action of a third party attempting to contact the user so there is no point in attempting the user to do anything). I would say something like "you have no missed calls"

2.2) hide the 'all' and 'missed call' tabs. Reasoning being if we are going to hid the 'missed call tab' we might as well hide the 'all' tab as well as there are no other filters that the end user can engage to reduce the list under the 'all' tab.

> 3.- The missed call is the last call inside a day header. It is the last
> missed call in the Call Log and also the latest entry in the Call Log. In
> this case and according to the current implementation, we show the "No calls
> recorded. Start communicating now" screen in the "Missed" and "All" tabs.
> Thanks!

Again, it would be preferable to do one of two things: 

3.1) to have two different messages for each tab

3.1.1) for the 'all' tab output "No calls recorded. Start communicating now"
3.1.2) for the missed call tab output "you have no missed calls"

3.2) hide both the 'all' and 'missed call' tabs and output "No calls recorded. Start communicating now"

..it has never made any sense to me to show both tabs when there is no content so i would encourage you to move towards hiding tabs that have no content under them which would mean implanting 2.2 and 3.2 …But if this is technically not feasible implement 2.1 and 3.1

NeedInfo me if you require further input

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

According to the current implementation it is easier to disable the "Missed" tab when there are no calls in that tab (option 3.2). The problem with that option is the case when there is 1 call for example in the "Missed" tab and the user decides to delete it. In that case, the user may get a little lost if we decide to disable or to hide the "Missed" tab (I guess that showing her the "All" tab contents). So, although kind of more complex to solve (according to the current implementation), I would go for option 3.1.

If you need any help, Mihai, please do not hesitate to ping me ;-) Thanks!

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10821 - Show different empty call log messages

Implemented the different empty call log messages option (3.1 from comment 4) and added extra checks for correctly updating the call log state when performing delete or update (i.e. new call) options.

Comment 7

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Germán for taking a look at the patch and spotting the issue with deleting the last remaining call that is a missed call (this is fixed now).

Adding :l10n to the loop for the prospective message when displaying empty missed call log. The current patch shows "No missed calls" for the Missed tab, to go with the "No calls recorded" for the All tab.

Feel free to suggest another string for informing the user that there are no missed calls to display.

Comment 8

[Axel Hecht [:Pike]]

https://groups.google.com/forum/#!topic/mozilla.dev.gaia/_T_BTvJ4fJk has guidelines on when to ask the l10n team and when to ask other folks. I think that in this case, you're looking for UX input.

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Requesting info from UX regarding the new "No missed calls". This text is shown in the Call Log when the "Missed" tab is selected and no missed calls exist. If you would like us to use any other text, please let us know. If the text is fine, please confirm it ;-) Thanks!

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

To help the UX team, I have prepared a couple of videos with the patch applied. I will attach them in a sec.

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: No "All" calls and no "Missed" calls

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 1 or more "All" calls and no "Missed" calls

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Deleting calls from "Missed" and "All" tabs

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: New incoming (missed) call

This is probably the most controversial change for which we need confirmation. As you will see in the call, if the Call Log is in the "Missed" tab and a new (missed) incoming call reaches the phone, the Call Log is automatically shown in the "All" tab. I do not know if this is the desired behavior. Is it?

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

Requesting info from Ayman regarding the new functionality included in this patch and shown in the videos/attachments ;-)

Comment 16

[ayman maat :maat]

(In reply to gtorodelvalle from comment #14)
> Created attachment 772542 [details]
> New incoming (missed) call
> 
> This is probably the most controversial change for which we need
> confirmation. As you will see in the call, if the Call Log is in the
> "Missed" tab and a new (missed) incoming call reaches the phone, the Call
> Log is automatically shown in the "All" tab. I do not know if this is the
> desired behavior. Is it?

It would be desirable if the call log maintained the view it had before the incoming call was received but I do not see this switch to the other tab as being huge issue.

Comment 17

[ayman maat :maat]

(In reply to gtorodelvalle from comment #15)
> Requesting info from Ayman regarding the new functionality included in this
> patch and shown in the videos/attachments ;-)

From the video's attached it seems fine to me.

Comment 18

[Etienne Segonzac (:etienne)]

Comment on attachment 771857 [details]
Pull Request #10821 - Show different empty call log messages

Forwarding the review to German :)
(Looks like you already have a good vision of this patch.)

Comment 19

[Germán Toro del Valle (:gtorodelvalle)]

Thanks Etienne ;-)

Since Ayman is fine with the proposed behavior, I am too :-)

Mihail, I included a last comment in the PR to try to improve performance when deleting Call Log entries.

Comment 20

[Germán Toro del Valle (:gtorodelvalle)]

Sorry, I meant Mihai ;-)

Comment 21

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Germán, feel free to check the latest version of the patch on GitHub and let me know if it looks fine. Thanks!

Comment 22

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 771857 [details]
Pull Request #10821 - Show different empty call log messages

Looking awesome to me! ;-) Thank you very much for a very productive discussion, Mihai ;-)

Comment 23

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thank you Germán for all the insightful comments and constructive feedback :)

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/a3ff442ce7bdf3cf370ac1513816a48e7fb5a777

Comment 25

[Anthony Ricaud (:rik)]

Requesting leo+ since bug 899506 was leo+ and uplifting this will fix it.

Comment 26

[bhavana bajaj [:bajaj]]

Blocking as this fixes a regression which is a blocker 899506.

Comment 27

[Anthony Ricaud (:rik)]

Merge in v1-train with 2986ad8fa02debc58e6700b52018f16a8e4a97d1.

Comment 28

[Axel Hecht [:Pike]]

Don't forget the late-l10n keyword if you nominate bugs with string changes.

Comment 29

[Montoya Clemmons (MClemmons)]

Verified fixed. The issue no longer reproduces. 

The entry is removed, the call log is empty

Environmental Variables
Build ID: 20130805071207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 45f6a739b09292e16717fb21003386c914ca29c2
Platform Version: 18.1
Firmware Version: D300f08o

Comment 30

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 2986ad8fa02debc58e6700b52018f16a8e4a97d1

Comment 31

[sarsenyev]

As per comment 7, the new strings for "Missed Call" was implemented on all locales

Environmental  Variables:
Build ID: 20130815041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/692d3414bb12
Gaia: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
Platform Version: 18.1
RIL Version: 01.01.00.019.190
Firmware verision: D300f080