883196 - Polish diacritical characters don't display correctly

Status: RESOLVED FIXED

(Input :: General, defect)

Description

[Stefan Plewako [:stef]]

The very same thing again and again… :(
Steps to reproduce:
Visit https://input.mozilla.org/pl/feedback
In Polish version characters like "ę, ó, ą, ś, ł, ż, ź, ć, ń" don't display correctly.

Actual results:
Default font probably doesn't contain Polish characters, so they are displayed using other font.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Stefan Plewako [:stef] from comment #0)
> Actual results:
> Default font probably doesn't contain Polish characters, so they are
> displayed using other font.

As far as I can tell, we aren't using any custom fonts: `font-family: Helvetica,Arial,sans-serif;`. Does that depend on the font installed on your system?

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

What operating system are you testing with?

Comment 3

[Stefan Plewako [:stef]]

Attachment: Screenshot

Mac OS X 10.8.4 and Firefox 22pl (beta).

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Stefan Plewako [:stef] from comment #3)
> Created attachment 763548 [details]
> Screenshot
> 
> Mac OS X 10.8.4 and Firefox 22pl (beta).

That's what I was guessing. We probably just need to add an OS-X friendly font to the list. Adding "Helvetica Neue" fixes it for me.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/fjord/pull/124

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/fjord/commit/b78b6b36a6881312cba09df9011f92bafa49cdb0

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Finally deployed this.