883208 - Give better error warning on duplicate titles

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

Attachment: generic warning

Currently we give a generic warning. This is no good.

Attached a screen shot.

Replace with "You already have a title with that name.  Please choose a new title using the <title> tag."

Comment 1

[Pomax]

Didn't we already fix this in #881595?

Comment 2

[Brett Gaylor [:brett]]

Perhaps, but can confirm on production that if you try and make two things with same title you get generic error message vs what i see in #881595

Did that ticket land after latest build?

Comment 3

[Scott [:thecount] Downe]

Brett, that is a different error not caused by duplicate titles.

Not yet sure what causes it, but I think it is login issues. Might be related to bug 883155

We suspect it'll be gone once things get updated.

I have not been able to reproduce it, and next time it happens see if it happens again without changing the name.

The current error for duplicate titles is:

Sorry, an error occurred while trying to publish. You already have a page titled "your-awesome-webpage-created-on-fri-14-jun-2013-165953-gmt" (you will have to change the text in the <title> element on your page)

I like your error better.

Comment 4

[Scott [:thecount] Downe]

Never mind most of that last comment, it DOES throw that error.

It should not. This is a bug. Even the old message was not that.

Comment 5

[Scott [:thecount] Downe]

So I just talked to Jon, Looks like this is something production just does, and hides all errors.

Comment 6

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/125

This fixes it.

To test run thimble like so:

NODE_ENV=production node app

Comment 7

[Pomax]

Comment on attachment 762763 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/125

this seems to just turn any error into a "500" error, which is going to make it really hard to figure out what's going wrong for us without server debugging. Popcorn has the nice error reporter, thimble doesn't, so is a "500" catch-all a sensible thing to do?

Comment 8

[Scott [:thecount] Downe]

Pomax could we consider landing this as is and fixing it next week?

More people are going to hit duplicate page title names than report bugs because of internal server errors.

I'm game for fixing it, but anywhere we can create slack is good for everyone else.

Comment 9

[Pomax]

sold. file a followup ticket, link to it, and I'll give it an r+, in that order.

Comment 10

[Scott [:thecount] Downe]

Comment on attachment 762763 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/125

bug 883379

Comment 11

[Pomax]

Comment on attachment 762763 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/125

make it happen.

Comment 12

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/e8849a35c17cb481805e7371621f5e64168b908f