88328 - PSM xul need some cleanup

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Stephane Saux]

* in several xul files, you have orient="horizontal" on buttons, which seems
unnecessary.
[e-mail] made the following comments on bug 86548
* I don't understand why you need to put style="width: 10ex" on all those
buttons.  The theme should define the size of those buttons.

* these files are missing type="application/x-javascript" on most of the script
tags.

Actually, the last 3 comments are not relevant to the changes you're making,
they're more general problems with the affected files.  I'll give an sr=hewitt
for this patch, but I suggest you address these other issues in the future.

Comment 1

[Stephane Saux]

target 2.1
p3

Comment 2

[Stephen Walker]

hewitt: 
class="normal" is on some of the buttons, is that needed?
should "chrome://pippki/content/" be added to js & overlay links such as 
src="certManager.js" & href="MineOverlay.xul"?
onclick= should be converted to oncommand=, right?
if the onclick= -> oncommand= change is made, do the buttons still need 
onkeypress=? 

Comment 3

[Stephen Walker]

should all instances of debug="false" be removed too? I removed them from 
serverCertExpired.xul & certDump.xul & didn't see any problems.

Comment 4

[Joe Hewitt (gone)]

- class="normal" may be needed still
- yes, all chrome urls should be absolute
- yes, you can combine onkeypress and onclick into oncommand, if they were both
doing the same thing

Comment 5

[Stephen Walker]

Attachment: patch #1

Comment 6

[Stephen Walker]

Attachment: patch #2; fix missing " in prefoverlay.xul

Comment 7

[Stephane Saux]

Moving all P3 and P4 bugs targetted to 2.1 to future.

Comment 8

[John Unruh]

Mass assigning QA to ckritzer.

Comment 9

[Stephen Walker]

Attachment: updated patch

Comment 10

[Javier Delgadillo]

r=javi

Comment 11

[Stephane Saux]

*** Bug 94203 has been marked as a duplicate of this bug. ***

Comment 12

[Joe Hewitt (gone)]

sr=hewitt

Comment 13

[(Don't use, old account) - Kai Engert]

Patch checked in

Comment 14

[Stephen Walker]

-> fixed

Comment 15

[Stephane Saux]

Assigning target of 2.1 to all bugs fixed in the 2.1 target timeframe whose
target was not 2.1

Comment 16

[John Unruh]

Verified.