PSM xul need some cleanup

VERIFIED FIXED in psm2.1

Status

Core Graveyard
Security: UI
P3
normal
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: Stephane Saux, Assigned: Stephane Saux)

Tracking

1.0 Branch
psm2.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

17 years ago
* in several xul files, you have orient="horizontal" on buttons, which seems
unnecessary.
hewitt@netscape.com made the following comments on bug 86548
* I don't understand why you need to put style="width: 10ex" on all those
buttons.  The theme should define the size of those buttons.

* these files are missing type="application/x-javascript" on most of the script
tags.

Actually, the last 3 comments are not relevant to the changes you're making,
they're more general problems with the affected files.  I'll give an sr=hewitt
for this patch, but I suggest you address these other issues in the future.
(Assignee)

Comment 1

17 years ago
target 2.1
p3
Priority: -- → P3
Target Milestone: --- → 2.1

Comment 2

17 years ago
hewitt: 
class="normal" is on some of the buttons, is that needed?
should "chrome://pippki/content/" be added to js & overlay links such as 
src="certManager.js" & href="MineOverlay.xul"?
onclick= should be converted to oncommand=, right?
if the onclick= -> oncommand= change is made, do the buttons still need 
onkeypress=? 

Comment 3

17 years ago
should all instances of debug="false" be removed too? I removed them from 
serverCertExpired.xul & certDump.xul & didn't see any problems.

Comment 4

17 years ago
- class="normal" may be needed still
- yes, all chrome urls should be absolute
- yes, you can combine onkeypress and onclick into oncommand, if they were both
doing the same thing

Updated

17 years ago
Keywords: patch, review

Comment 6

17 years ago
Created attachment 42556 [details] [diff] [review]
patch #2; fix missing " in prefoverlay.xul
(Assignee)

Comment 7

17 years ago
Moving all P3 and P4 bugs targetted to 2.1 to future.
Target Milestone: 2.1 → Future

Comment 8

17 years ago
Mass assigning QA to ckritzer.
QA Contact: junruh → ckritzer

Comment 9

17 years ago
Created attachment 44842 [details] [diff] [review]
updated patch

Comment 10

17 years ago
r=javi
(Assignee)

Comment 11

17 years ago
*** Bug 94203 has been marked as a duplicate of this bug. ***

Comment 12

17 years ago
sr=hewitt

Comment 13

17 years ago
Patch checked in

Comment 14

17 years ago
-> fixed
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

17 years ago
Assigning target of 2.1 to all bugs fixed in the 2.1 target timeframe whose
target was not 2.1
Target Milestone: Future → 2.1

Comment 16

17 years ago
Verified.
Status: RESOLVED → VERIFIED
QA Contact: ckritzer → junruh

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core

Updated

10 years ago
Version: psm2.0 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.