Closed
Bug 88328
Opened 23 years ago
Closed 23 years ago
PSM xul need some cleanup
Categories
(Core Graveyard :: Security: UI, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
psm2.1
People
(Reporter: ssaux, Assigned: ssaux)
Details
Attachments
(3 files)
66.17 KB,
patch
|
Details | Diff | Splinter Review | |
66.17 KB,
patch
|
Details | Diff | Splinter Review | |
83.99 KB,
patch
|
Details | Diff | Splinter Review |
* in several xul files, you have orient="horizontal" on buttons, which seems unnecessary. hewitt@netscape.com made the following comments on bug 86548 * I don't understand why you need to put style="width: 10ex" on all those buttons. The theme should define the size of those buttons. * these files are missing type="application/x-javascript" on most of the script tags. Actually, the last 3 comments are not relevant to the changes you're making, they're more general problems with the affected files. I'll give an sr=hewitt for this patch, but I suggest you address these other issues in the future.
Comment 2•23 years ago
|
||
hewitt: class="normal" is on some of the buttons, is that needed? should "chrome://pippki/content/" be added to js & overlay links such as src="certManager.js" & href="MineOverlay.xul"? onclick= should be converted to oncommand=, right? if the onclick= -> oncommand= change is made, do the buttons still need onkeypress=?
Comment 3•23 years ago
|
||
should all instances of debug="false" be removed too? I removed them from serverCertExpired.xul & certDump.xul & didn't see any problems.
Comment 4•23 years ago
|
||
- class="normal" may be needed still - yes, all chrome urls should be absolute - yes, you can combine onkeypress and onclick into oncommand, if they were both doing the same thing
Comment 5•23 years ago
|
||
Updated•23 years ago
|
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
Moving all P3 and P4 bugs targetted to 2.1 to future.
Target Milestone: 2.1 → Future
Comment 9•23 years ago
|
||
Comment 10•23 years ago
|
||
r=javi
Assignee | ||
Comment 11•23 years ago
|
||
*** Bug 94203 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
sr=hewitt
Comment 13•23 years ago
|
||
Patch checked in
Assignee | ||
Comment 15•23 years ago
|
||
Assigning target of 2.1 to all bugs fixed in the 2.1 target timeframe whose target was not 2.1
Target Milestone: Future → 2.1
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•