883298 - [FTU] Check whether there is no need to retrieve the APN settings from the apn.json database

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

The FTU app is retrieving the APN settings from the apn.json database directly. There might be no need to retrieve them from there since the preferred APN settings are already stored into the setting database. Remember the operator variant logic retrieves the APN settings from the apn.json database and store them into the settings database on boot. This bug is for checking if that is possible since there might be race-condition issues.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v1

Just a clean up in the FTU app about the old APN settings architecture. Ken, your feedback is really appreciate!, Fernando, could you take a look please? Thanks!

Comment 2

[Fernando Campo (:fcampo)]

Comment on attachment 801624 [details] [diff] [review]
v1

Review of attachment 801624 [details] [diff] [review]:
-----------------------------------------------------------------

Just couple of style nits, but seems nice to me. Only tested it on normal conditions, I'm not sure how to provoke the apn not to be loaded at first.

::: apps/communications/ftu/js/data_mobile.js
@@ +51,5 @@
> +    // enabling data calls.
> +    var _self = this;
> +    function ensureAPNSettings() {
> +      var req = _self.settings.createLock().get('ril.data.apnSettings');
> +      req.onsuccess = function() {

nit: better if function is not anonymous

@@ +55,5 @@
> +      req.onsuccess = function() {
> +        var apnSettings = req.result['ril.data.apnSettings'];
> +        if (apnSettings) {
> +          if (callback) {
> +            callback();

nit: if (apnSettings && callback)

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: v2

Fix unit test failures. Fernando, would you review this patch again please? Thanks.

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 803116 [details] [diff] [review]
v2

Travis failing but not related to the changes.

Thanks for your work!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/da4cb0c60f61e112c4299444d4846485499721a4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out because either this or bug 912904 was causing Gaia UI Test failures.
https://github.com/mozilla-b2g/gaia/commit/70800e30b4e8f1162d32bcff4228216b524ffee2

https://tbpl.mozilla.org/php/getParsedLog.php?id=27715778&tree=B2g-Inbound

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/4b14d71cfbafa1bdd3ae0766b5d2f5c7a36810dc

Landed again after checking the failure is not related to the changes. Sorry for the noise.