883307 - Find a better jQuery dep loading solution in webmaker.org

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: webmaker.org, defect)

Description

[David Humphrey (:humph)]

In bug 879298 we added a workaround for an intermittent jquery load ordering issue.  The sso-ux.js file requires JS, and will load its own if not present.  Tabzilla is the same, but we manage to subvert that one being a problem by loading it via require.js, which also loads its own jquery.  What happens (or happened before that fix) is that the load of the first jquery could be started, but `if($)` returned false, causing a second load to happen.  The second load meant that the jquery plugin got put on the wrong instance of jquery, and then the method wasn't there when needed.

The solution here is to somehow load sso-ux.js through require.js, but deal with the fact that we have to do templating to get the loginAPI written out based on node.js env variables.

What we have now is "good enough" but not very elegant, and is a bit brittle if script ordering changes, or new files are added that also need this pattern.

Comment 1

[Pomax]

is this still required?

Comment 2

[David Humphrey (:humph)]

Good enough's good enough.