With OMTC enabled on Metro Firefox, we crash when scrolling

RESOLVED FIXED in mozilla24

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bbondy, Assigned: bas.schouten)

Tracking

({crash})

unspecified
mozilla24
x86_64
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch Patch v1.Splinter Review
OMTC is currently disabled by default on Metro Firefox, but when you enable it you get a crash every time you scroll.

I tracked a problem down in DrawTargetD2D.cpp inside DrawTargetD2D::CopySurface.  In particular if I comment out the call to mRT->DrawBitmap in that function I no longer get a crash.  I verified and mRT->BeginDraw() is being called before DrawBitmap.

Before the crash, in the output debug window I get this message:
> D2D DEBUG ERROR - An attempt to draw from an inaccessible bitmap has been detected.

Here's the call stack (not of the crash, but of the call that if commented out no longer crashes)
http://pastebin.com/5NUygaGf 

Bas suggested a patch on IRC which I verified does fix the problem, and I'm attaching it here.
Attachment #762878 - Flags: review?(jmuizelaar)
Patch author is Bas, I'm just coordinating the bug posting / patch posting / review request.
Attachment #762878 - Attachment is patch: true
Attachment #762878 - Attachment mime type: text/x-patch → text/plain
Keywords: crash
Attachment #762878 - Flags: review?(jmuizelaar) → review+
Thanks for the review, Bas I pushed your patch to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a111fc485061
Target Milestone: --- → mozilla24
https://hg.mozilla.org/mozilla-central/rev/a111fc485061
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.