Closed
Bug 883352
Opened 11 years ago
Closed 11 years ago
With OMTC enabled on Metro Firefox, we crash when scrolling
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: bbondy, Assigned: bas.schouten)
References
Details
(Keywords: crash)
Attachments
(1 file)
|
1.06 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
OMTC is currently disabled by default on Metro Firefox, but when you enable it you get a crash every time you scroll. I tracked a problem down in DrawTargetD2D.cpp inside DrawTargetD2D::CopySurface. In particular if I comment out the call to mRT->DrawBitmap in that function I no longer get a crash. I verified and mRT->BeginDraw() is being called before DrawBitmap. Before the crash, in the output debug window I get this message: > D2D DEBUG ERROR - An attempt to draw from an inaccessible bitmap has been detected. Here's the call stack (not of the crash, but of the call that if commented out no longer crashes) http://pastebin.com/5NUygaGf Bas suggested a patch on IRC which I verified does fix the problem, and I'm attaching it here.
Attachment #762878 -
Flags: review?(jmuizelaar)
|
Reporter | |
Comment 1•11 years ago
|
||
Patch author is Bas, I'm just coordinating the bug posting / patch posting / review request.
|
|
Reporter | |
Updated•11 years ago
|
Attachment #762878 -
Attachment is patch: true
Attachment #762878 -
Attachment mime type: text/x-patch → text/plain
|
||
Updated•11 years ago
|
Attachment #762878 -
Flags: review?(jmuizelaar) → review+
|
|
Reporter | |
Comment 2•11 years ago
|
||
Thanks for the review, Bas I pushed your patch to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/a111fc485061
Target Milestone: --- → mozilla24
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a111fc485061
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•