883381 - SpiderMonkey does not support C++11 yet

Status: RESOLVED WORKSFORME

Description

[Terrence Cole [:terrence]]

Created attachment 762915 [details] [diff] [review]
v0

I'm not sure why this is still building successfully on tbpl; it certainly isn't building locally.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 762915 [details] [diff] [review]
v0

Review of attachment 762915 [details] [diff] [review]:
-----------------------------------------------------------------

As a hackaround til we fix the underlying issues, okay.

::: js/src/configure.in
@@ +2341,1 @@
>      USE_CXX11=1

I think you want to have USE_CXX11= as well here.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd67ffb5ca47

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd67ffb5ca47

Comment 4

[Mike Hommey [:glandium]]

(In reply to Terrence Cole [:terrence] from comment #0)
> Created attachment 762915 [details] [diff] [review]
> v0
> 
> I'm not sure why this is still building successfully on tbpl; it certainly
> isn't building locally.

When filing bugs like this, it would be useful to have a trace of your build errors. TBPL not failing to build is maybe evidence that something is wrong with your toolchain, which doesn't necessarily grant this change.

Comment 5

[Mike Hommey [:glandium]]

BTW, neither clang 3.4 nor gcc 4.8 fail to build standalone js on linux for me. I'm tempted to back this out.

Comment 6

[Mike Hommey [:glandium]]

I spoke too quickyl, I got an error with clang, which, interestingly, has not much to do with C++11... and is actually a real bug in the code.

Comment 7

[Mike Hommey [:glandium]]

Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b

Comment 8

[Jan de Mooij [:jandem]]

(In reply to Mike Hommey [:glandium] from comment #7)
> Backed out.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b

I think this broke the OS X Opt SpiderMonkey build:

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey

Looks like a Clang/LLVM crash..

Comment 9

[Mike Hommey [:glandium]]

(In reply to Jan de Mooij [:jandem] from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #7)
> > Backed out.
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b
> 
> I think this broke the OS X Opt SpiderMonkey build:
> 
> https://tbpl.mozilla.org/?tree=Mozilla-
> Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey
> 
> Looks like a Clang/LLVM crash..

Most likely because of bug 895208.