Closed
Bug 883381
Opened 12 years ago
Closed 12 years ago
SpiderMonkey does not support C++11 yet
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
WORKSFORME
mozilla24
People
(Reporter: terrence, Unassigned)
References
Details
Attachments
(1 file)
924 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
I'm not sure why this is still building successfully on tbpl; it certainly isn't building locally.
Attachment #762915 -
Flags: review?(jwalden+bmo)
Comment 1•12 years ago
|
||
Comment on attachment 762915 [details] [diff] [review]
v0
Review of attachment 762915 [details] [diff] [review]:
-----------------------------------------------------------------
As a hackaround til we fix the underlying issues, okay.
::: js/src/configure.in
@@ +2341,1 @@
> USE_CXX11=1
I think you want to have USE_CXX11= as well here.
Attachment #762915 -
Flags: review?(jwalden+bmo) → review+
Reporter | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Comment 4•12 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #0)
> Created attachment 762915 [details] [diff] [review]
> v0
>
> I'm not sure why this is still building successfully on tbpl; it certainly
> isn't building locally.
When filing bugs like this, it would be useful to have a trace of your build errors. TBPL not failing to build is maybe evidence that something is wrong with your toolchain, which doesn't necessarily grant this change.
Comment 5•12 years ago
|
||
BTW, neither clang 3.4 nor gcc 4.8 fail to build standalone js on linux for me. I'm tempted to back this out.
Comment 6•12 years ago
|
||
I spoke too quickyl, I got an error with clang, which, interestingly, has not much to do with C++11... and is actually a real bug in the code.
Comment 7•12 years ago
|
||
Resolution: FIXED → WORKSFORME
Comment 8•12 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #7)
> Backed out.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b
I think this broke the OS X Opt SpiderMonkey build:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey
Looks like a Clang/LLVM crash..
Comment 9•12 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #7)
> > Backed out.
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b
>
> I think this broke the OS X Opt SpiderMonkey build:
>
> https://tbpl.mozilla.org/?tree=Mozilla-
> Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey
>
> Looks like a Clang/LLVM crash..
Most likely because of bug 895208.
You need to log in
before you can comment on or make changes to this bug.
Description
•