SpiderMonkey does not support C++11 yet

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: terrence, Unassigned)

Tracking

Trunk
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 762915 [details] [diff] [review]
v0

I'm not sure why this is still building successfully on tbpl; it certainly isn't building locally.
Attachment #762915 - Flags: review?(jwalden+bmo)

Comment 1

6 years ago
Comment on attachment 762915 [details] [diff] [review]
v0

Review of attachment 762915 [details] [diff] [review]:
-----------------------------------------------------------------

As a hackaround til we fix the underlying issues, okay.

::: js/src/configure.in
@@ +2341,1 @@
>      USE_CXX11=1

I think you want to have USE_CXX11= as well here.
Attachment #762915 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/cd67ffb5ca47
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Blocks: 877937
(In reply to Terrence Cole [:terrence] from comment #0)
> Created attachment 762915 [details] [diff] [review]
> v0
> 
> I'm not sure why this is still building successfully on tbpl; it certainly
> isn't building locally.

When filing bugs like this, it would be useful to have a trace of your build errors. TBPL not failing to build is maybe evidence that something is wrong with your toolchain, which doesn't necessarily grant this change.
BTW, neither clang 3.4 nor gcc 4.8 fail to build standalone js on linux for me. I'm tempted to back this out.
I spoke too quickyl, I got an error with clang, which, interestingly, has not much to do with C++11... and is actually a real bug in the code.
(In reply to Mike Hommey [:glandium] from comment #7)
> Backed out.
> https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b

I think this broke the OS X Opt SpiderMonkey build:

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey

Looks like a Clang/LLVM crash..
(In reply to Jan de Mooij [:jandem] from comment #8)
> (In reply to Mike Hommey [:glandium] from comment #7)
> > Backed out.
> > https://hg.mozilla.org/integration/mozilla-inbound/rev/af7c55ced80b
> 
> I think this broke the OS X Opt SpiderMonkey build:
> 
> https://tbpl.mozilla.org/?tree=Mozilla-
> Inbound&showall=1&rev=5939320824b1&jobname=spidermonkey
> 
> Looks like a Clang/LLVM crash..

Most likely because of bug 895208.
You need to log in before you can comment on or make changes to this bug.