883392 - clean up TabChild.h's #includes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

I was modifying nsIDOMWindowUtils.idl today and noticed that touching it caused
an unusual amount of stuff to be built.  This was triggered by TabChild.h
including nsIDOMWindowUtils.h.

But that's totally unnecessary.  The only reason TabChild.h does that is because
there's an inline method that requires the full definition of nsIDOMWindowUtils.
However, that inline method is also private and therefore has no business being
in the header.  We can move it into the implementation file with no loss of
functionality.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: clean up TabChild.h's #includes

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 762935 [details] [diff] [review]
clean up TabChild.h's #includes

This patch cleans things up by moving GetDOMWindowUtils into the implementation file so that we can just forward declare nsIDOMWindowUtils and reduce #include pollution.

I also took the liberty of making GetDOMWindowUtils return already_AddRefed and deleted a bunch of unnecessary #includes from TabChild.h.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5d6ca382991