Closed Bug 883392 Opened 8 years ago Closed 8 years ago

clean up TabChild.h's #includes

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

I was modifying nsIDOMWindowUtils.idl today and noticed that touching it caused
an unusual amount of stuff to be built.  This was triggered by TabChild.h
including nsIDOMWindowUtils.h.

But that's totally unnecessary.  The only reason TabChild.h does that is because
there's an inline method that requires the full definition of nsIDOMWindowUtils.
However, that inline method is also private and therefore has no business being
in the header.  We can move it into the implementation file with no loss of
functionality.
Comment on attachment 762935 [details] [diff] [review]
clean up TabChild.h's #includes

This patch cleans things up by moving GetDOMWindowUtils into the implementation file so that we can just forward declare nsIDOMWindowUtils and reduce #include pollution.

I also took the liberty of making GetDOMWindowUtils return already_AddRefed and deleted a bunch of unnecessary #includes from TabChild.h.
Attachment #762935 - Flags: review?(bugs)
Attachment #762935 - Flags: review?(bugs) → review+
Assignee: nobody → nfroyd
https://hg.mozilla.org/mozilla-central/rev/b5d6ca382991
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.