Closed
Bug 883396
Opened 13 years ago
Closed 13 years ago
Remove text from redirect page
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: humph, Assigned: michiel)
Details
Attachments
(1 file)
When you go to https://webmaker.makes.org/thimble/wish-you-were-here/remix, we do a redirect. In chrome, it just happens. In Firefox, it takes Nms, and during that time, we show some text. Let's not do that.
Also, consider a better zero-timeout solution: http://dbaron.org/log/20100309-faster-timeouts
|
Reporter | |
Comment 1•13 years ago
|
||
Scott, can you figure out if PM needs this fix too?
Attachment #762941 -
Flags: review?(david.humphrey)
|
|
Reporter | |
Comment 3•13 years ago
|
||
Comment on attachment 762941 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/129
Two things that might be worth doing, even though pedantic:
1) Add doctype - <!DOCTYPE html>
2) Change single-quote to double-quote in meta attributes.
With those, it will validate better. Shouldn't matter, but will make sure it's a valid doc. You decide, I'm happy either way.
Attachment #762941 -
Flags: review?(david.humphrey) → review+
|
||
Comment 5•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org
https://github.com/mozilla/thimble.webmaker.org/commit/4f363c2726c5801f328d10770eff653a535c2397
Merge pull request #129 from Pomax/bug883396
made redirect textless
landed.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•