Closed Bug 883436 Opened 7 years ago Closed 7 years ago

Remove prtypes.h #include from nsString.h

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
PRUnichar is defined in nscore.h <= nsStringFwd.h <= nsAString.h <= nsSubstring.h.
https://mxr.mozilla.org/mozilla-central/source/xpcom/base/nscore.h?rev=13c33b6d787d#336
We shouldn't pull in all PR* junks only for PRUnichar.

No compile error on try: https://tbpl.mozilla.org/?tree=Try&rev=21856eb2bf81
Attachment #762989 - Flags: review?(ehsan)
Comment on attachment 762989 [details] [diff] [review]
patch

Review of attachment 762989 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!
Attachment #762989 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Attachment #762989 - Attachment is obsolete: true
Attachment #763880 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/03b202a6f343
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/03b202a6f343
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.