Upgrade django-cache-machine to 0.8

VERIFIED FIXED in 2013-10-14

Status

P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: robhudson, Assigned: mat)

Tracking

2013-10-14
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

5 years ago
Django cache machine 0.8 has some fixes for Django 1.4 and also for multi-db setups. I upgraded quickly, fixed a few backwards incompatible things and discovered there were quite a few test errors afterwards.

Counts, e.g., seems to have changed. I found a few of these:

   eq_(qs.count(), old_cnt + 1)
AssertionError: 0 != 1

   eq_(EscalationQueue.objects.filter(addon=self.app).count(), 1)
AssertionError: 0 != 1

etc.

Work in progress patch on this branch:
https://github.com/robhudson/zamboni/tree/upgrade-cache-machine
"How about delete django cache machine" -- ashort


-> rob due to patch in progress. sry! :)
Assignee: nobody → robhudson.mozbugs
Priority: -- → P3
(Assignee)

Updated

5 years ago
Blocks: 846349
(Assignee)

Comment 2

5 years ago
One thing to note, I think I might have discovered a bug in our version: no_cache() doesn't seem to working on count()s. Since there are changes related to counts in 0.8 it might be interesting to investigate further.
(Assignee)

Comment 3

5 years ago
So, that bug with no_cache() and count()s has been fixed 2 years ago in cache-machine. Let's try to upgrade.
Assignee: robhudson.mozbugs → mpillard
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

5 years ago
This change is related to how we cache stuff and can affect all marketplace. So here are some generic STRs to test that we didn't break anything major with it:

STR:
- Load marketplace devhub, submit an app, see if everything looks ok in the process
- Wait a couple minutes, load the reviewer tools, see if you can see your app in the queue
- Approve the app, see if it becomes public on the marketplace like it should.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2013-10-07

Comment 6

5 years ago
Verified as fixed in https://marketplace-dev.allizom.org/ on FF 27 (Win 7).
Postfix screencast http://screencast.com/t/RAwoYnUKw
Closing bug.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
Target Milestone: 2013-10-07 → 2013-10-14
You need to log in before you can comment on or make changes to this bug.