883483 - Improved handling of missing picture or registerLink in event-details view

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, enhancement)

Description

[hike]

Attachment: screenshot of event with picture and link

Let me know what you think of the screenshots.
This has been implemented here, ready to merge: https://github.com/mozilla/webmaker-events/tree/details-gallery

Comment 1

[hike]

Attachment: screenshot of event with link, without picture

Comment 2

[hike]

Attachment: screenshot of event with picture, no link

Comment 3

[hike]

Cassie, can you see if this fixes any of the event-details styling issues?

Comment 4

[Cassie McDaniel [:cassiemc]]

I see what you mean. The button placement does look better when it is inside a coloured box.

I'd prefer the text column to be quite a bit narrower, or maybe it's just because the screenshot is on hi-res and I'm on a laptop. You can look at the other subpages - eg. webmaker.org/privacy - for a guide on column width, text size, text colour, text weight, and line spacing.

The page still needs a buffer at the bottom, more space between the end of page and the footer.

I'd prefer the edit button was up near the title. Thanks!