refactor publishing so that we publish into a thimble "shell"

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: pomax, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
this will let us put the make details etc. in the outer shell, and iframe-load the thimble page inside it, solving a lot of injection/embedding problems.
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

5 years ago
Created attachment 765577 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/150

We should consider refactoring more of the publish middleware function. I just did what I needed to get the iframe fixed up.

We should look at how popcorn now does it: https://github.com/mozilla/popcorn.webmaker.org/blob/master/routes/api/publish.js#L17

We can do that refactor in this ticket or a new one.
Attachment #765577 - Flags: review?(pomax)
Blocks: 886291
(Reporter)

Comment 2

5 years ago
Comment on attachment 765577 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/150

not a fan of how we need a scrollbar for the iframe. we can fix this.
Attachment #765577 - Flags: review?(pomax) → review-
(Assignee)

Updated

5 years ago
Attachment #765577 - Flags: review- → review?(pomax)
(Reporter)

Comment 3

5 years ago
Comment on attachment 765577 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/150

After working on this together, this patch looks good to me.
Attachment #765577 - Flags: review?(pomax) → review+
(Assignee)

Comment 4

5 years ago
staged: https://github.com/mozilla/thimble.webmaker.org/commit/5e30b3d43371b427ffc0d80b3c8de33640ec3259
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.