Closed
Bug 883488
Opened 11 years ago
Closed 11 years ago
refactor publishing so that we publish into a thimble "shell"
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: thecount)
References
Details
Attachments
(1 file)
this will let us put the make details etc. in the outer shell, and iframe-load the thimble page inside it, solving a lot of injection/embedding problems.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → scott
|
|
Assignee | |
Comment 1•11 years ago
|
||
We should consider refactoring more of the publish middleware function. I just did what I needed to get the iframe fixed up. We should look at how popcorn now does it: https://github.com/mozilla/popcorn.webmaker.org/blob/master/routes/api/publish.js#L17 We can do that refactor in this ticket or a new one.
Attachment #765577 -
Flags: review?(pomax)
Comment on attachment 765577 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/150 not a fan of how we need a scrollbar for the iframe. we can fix this.
Attachment #765577 -
Flags: review?(pomax) → review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #765577 -
Flags: review- → review?(pomax)
Comment on attachment 765577 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/150 After working on this together, this patch looks good to me.
Attachment #765577 -
Flags: review?(pomax) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
staged: https://github.com/mozilla/thimble.webmaker.org/commit/5e30b3d43371b427ffc0d80b3c8de33640ec3259
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•