883492 - make details for published pages do not seem to resolve for everyone

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Pomax]

when publishing a thimble page, the "make details" page for it generally works for the person publishing, but may not resolve for other people looking at it. This might be a makeAPI issue, or a how-we-call-makeAPI issue, or even something else altogether.

Comment 1

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/MakeAPI/pull/87

Comment 2

[Pomax]

Comment on attachment 763746 [details] [review]
https://github.com/mozilla/MakeAPI/pull/87

I am willing to say "just make DELETED_FILTER" a function that returns the { ... } object we need. few seconds work. Cleaner.

Comment 3

[David Humphrey (:humph)]

Comment on attachment 763746 [details] [review]
https://github.com/mozilla/MakeAPI/pull/87

I don't like leaving the DELETED_FILTER up there.

Comment 4

[Pomax]

Comment on attachment 763746 [details] [review]
https://github.com/mozilla/MakeAPI/pull/87

\BOOM/

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/d57d64d63dd1fe1ece16996d05b20a5621767c36
Fix bug 883492 - Do not pass objects by reference

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/9fe3a0c7db722f971c05f46b6a0448ec6b3c4031
Bug 883492 - Update makeapi to v0.1.24

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/0808eb985b6db78680a571efa8ac0badeb12efe7
Bug 883492 - Update makeapi to v0.1.24

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/5e05e2d572556234c672e4dfb67fb778b88ed017
Bug 883492 - Update makeapi to v0.1.24