The default bug view has changed. See this FAQ.

Use arrowpopup for editContactPanel

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
The editContactPanel is a clone FX's editBookmarkPanel. This one uses since long time the arrowpopup.

I think we should follow this way. An advantage would also be, when FX changes some stylings in this arrowpopup, we adopt this automatically and don't need a separate bug to follow like we had (bug 801261).

This change is simple by adding type="arrow" and removing our own styling.
(Assignee)

Comment 1

4 years ago
Created attachment 763080 [details] [diff] [review]
patch

I had to change the popup position to after_start for rtl and ltr. The actual behavior is already wrong for rtl languages (the popup opens in the same direction as on ltr).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #763080 - Flags: ui-review?(bwinton)
Attachment #763080 - Flags: review?(bwinton)
(Assignee)

Comment 2

4 years ago
Created attachment 763081 [details]
patch in action
Comment on attachment 763080 [details] [diff] [review]
patch

Yes!  ui-r=me!  r=me!  So good.  :)

Thanks,
Blake.
Attachment #763080 - Flags: ui-review?(bwinton)
Attachment #763080 - Flags: ui-review+
Attachment #763080 - Flags: review?(bwinton)
Attachment #763080 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Attachment #763080 - Attachment is patch: true
Attachment #763080 - Attachment mime type: text/x-patch → text/plain
https://hg.mozilla.org/comm-central/rev/7e5dbdd024ae
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.