Closed
Bug 883506
Opened 11 years ago
Closed 11 years ago
Use arrowpopup for editContactPanel
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files)
|
4.66 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
|
11.03 KB,
image/png
|
Details |
patch in action
The editContactPanel is a clone FX's editBookmarkPanel. This one uses since long time the arrowpopup. I think we should follow this way. An advantage would also be, when FX changes some stylings in this arrowpopup, we adopt this automatically and don't need a separate bug to follow like we had (bug 801261). This change is simple by adding type="arrow" and removing our own styling.
|
Assignee | |
Comment 1•11 years ago
|
||
I had to change the popup position to after_start for rtl and ltr. The actual behavior is already wrong for rtl languages (the popup opens in the same direction as on ltr).
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #763080 -
Flags: ui-review?(bwinton)
Attachment #763080 -
Flags: review?(bwinton)
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Comment on attachment 763080 [details] [diff] [review] patch Yes! ui-r=me! r=me! So good. :) Thanks, Blake.
Attachment #763080 -
Flags: ui-review?(bwinton)
Attachment #763080 -
Flags: ui-review+
Attachment #763080 -
Flags: review?(bwinton)
Attachment #763080 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Updated•11 years ago
|
Attachment #763080 -
Attachment is patch: true
Attachment #763080 -
Attachment mime type: text/x-patch → text/plain
|
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/7e5dbdd024ae
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•