Last Comment Bug 883506 - Use arrowpopup for editContactPanel
: Use arrowpopup for editContactPanel
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 24.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-15 01:17 PDT by Richard Marti (:Paenglab)
Modified: 2013-06-25 05:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (4.66 KB, patch)
2013-06-15 01:24 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Review
patch in action (11.03 KB, image/png)
2013-06-15 01:34 PDT, Richard Marti (:Paenglab)
no flags Details

Description Richard Marti (:Paenglab) 2013-06-15 01:17:54 PDT
The editContactPanel is a clone FX's editBookmarkPanel. This one uses since long time the arrowpopup.

I think we should follow this way. An advantage would also be, when FX changes some stylings in this arrowpopup, we adopt this automatically and don't need a separate bug to follow like we had (bug 801261).

This change is simple by adding type="arrow" and removing our own styling.
Comment 1 Richard Marti (:Paenglab) 2013-06-15 01:24:13 PDT
Created attachment 763080 [details] [diff] [review]
patch

I had to change the popup position to after_start for rtl and ltr. The actual behavior is already wrong for rtl languages (the popup opens in the same direction as on ltr).
Comment 2 Richard Marti (:Paenglab) 2013-06-15 01:34:41 PDT
Created attachment 763081 [details]
patch in action
Comment 3 Blake Winton (:bwinton) (:☕️) 2013-06-16 13:28:03 PDT
Comment on attachment 763080 [details] [diff] [review]
patch

Yes!  ui-r=me!  r=me!  So good.  :)

Thanks,
Blake.
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-06-18 08:40:03 PDT
https://hg.mozilla.org/comm-central/rev/7e5dbdd024ae

Note You need to log in before you can comment on or make changes to this bug.