Closed
Bug 883523
Opened 11 years ago
Closed 11 years ago
if(1) /a/.test("a") causes Syntax Error after landing Bug 872735
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: alice0775, Assigned: jorendorff)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
1.03 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Build Identifier: http://hg.mozilla.org/mozilla-central/rev/3d16d59c9317 Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20130615 Firefox/24.0 ID:20130615031212 Steps To Reproduce: 1. Open Error Console (or Browser Console) 2. Execute the following code if(1) /a/.test("a"); Actual Results: Syntax Error Expected Results: No error, and should be "true" Regression window(m-c) Good: http://hg.mozilla.org/mozilla-central/rev/5ddb1bf96261 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130614 Firefox/24.0 ID:20130614100407 Bad: http://hg.mozilla.org/mozilla-central/rev/05d9196b27a1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130614 Firefox/24.0 ID:20130614184124 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5ddb1bf96261&tochange=05d9196b27a1 Regression window(m-i) Good: http://hg.mozilla.org/integration/mozilla-inbound/rev/9080f6701733 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130614 Firefox/24.0 ID:20130614142722 Bad: http://hg.mozilla.org/integration/mozilla-inbound/rev/cbf52dea3df1 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130614 Firefox/24.0 ID:20130614143422 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9080f6701733&tochange=cbf52dea3df1 In local build Last Good: 9080f6701733 First Bad: aaed29a8aeba Regressed by: aaed29a8aeba Jason Orendorff — Bug 872735, part 1 - Remove isEmptySemicolon from the ParseHandler protocol. It was only used for a warning about "if (foo);". r=Waldo.
Reporter | ||
Comment 1•11 years ago
|
||
Open https://www.google.com/search?q=Firefox SyntaxError: syntax error @ https://www.google.com/xjs/_/js/k=xjs.s.en_US.O4F8cgGsAy8.O/m=c,sb,cr,cdos,jp,vm,tbui,mb,wobnm,cfm,abd,bihu,kp,lu,m,tnv,amcl,erh,hv,lc,ob,r,rsn,sf,sfa,shb,tbpr,hsm,j,p,pcc,csi/am=wA/rt=j/d=1/sv=1/rs=AItRSTMxeKSo294ZI0DOMKyj3ZDYGUfhtA:1315
Assignee | ||
Comment 3•11 years ago
|
||
Whoops. Patching now.
Assignee | ||
Comment 4•11 years ago
|
||
One-token patch, plus test. It's a nice test to have...
Assignee: general → jorendorff
Attachment #763572 -
Flags: review?(jwalden+bmo)
Comment 5•11 years ago
|
||
Comment on attachment 763572 [details] [diff] [review] v1 Review of attachment 763572 [details] [diff] [review]: ----------------------------------------------------------------- Stealing review, after reading enough of Parser::statement(), TokenStream::getTokenInternal() and bug 872735 part 1 to understand why the change is needed.
Attachment #763572 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Landed two hours ago: https://hg.mozilla.org/integration/mozilla-inbound/rev/ccb80286042a ...but this turned out to be in the middle of lots of inbound bustage, so we're still waiting for it to cycle green...
Updated•11 years ago
|
status-firefox24:
--- → affected
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ccb80286042a
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•