883530 - Can't build fennec: js/src/ion/arm/Assembler-arm.h:30:33: error: both 'const' and 'constexpr' cannot be used here"

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Rouget [:paul]]

Attachment: logs

Apparently, several of us ran into the same issue today:

/usr/bin/ccache /home/paul/mozilla/fennec/android-ndk-r8e//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -o Debugger.o -c -fvisibility=hidden -DENABLE_PARALLEL_JS -DNO_NSPR_10_SUPPORT -DIMPL_MFBT -DEXPORT_JS_API -DJS_HAS_CTYPES -DDLL_PREFIX=\"lib\" -DDLL_SUFFIX=\".so\" -DUSE_ZLIB -Ictypes/libffi/include -I. -I/home/paul/mozilla/fennec/fennec/js/src/../../mfbt/double-conversion -I/home/paul/mozilla/fennec/fennec/js/src/../../intl/icu/source/common -I/home/paul/mozilla/fennec/fennec/js/src/../../intl/icu/source/i18n -I/home/paul/mozilla/fennec/fennec/js/src -I. -I./../../dist/include -I/home/paul/mozilla/fennec/fennec/objdir-droid/dist/include/nspr -I/home/paul/mozilla/fennec/fennec/js/src -I/home/paul/mozilla/fennec/fennec/js/src/assembler -I/home/paul/mozilla/fennec/fennec/js/src/yarr -fPIC -isystem /home/paul/mozilla/fennec/android-ndk-r8e//platforms/android-9/arch-arm/usr/include -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Werror=conversion-null -Wsign-compare -Wno-invalid-offsetof -mandroid -fno-short-enums -fno-exceptions -Wno-psabi -march=armv7-a -mthumb -mfpu=vfp -mfloat-abi=softfp -I/home/paul/mozilla/fennec/fennec/objdir-droid/build/stlport -I/home/paul/mozilla/fennec/android-ndk-r8e//sources/cxx-stl/stlport/stlport -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pipe -DNDEBUG -DTRIMMED -g -O3 -freorder-blocks -fno-reorder-functions -fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1 -isystem /home/paul/mozilla/fennec/android-ndk-r8e//platforms/android-9/arch-arm/usr/include -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MP -MF .deps/Debugger.o.pp /home/paul/mozilla/fennec/fennec/js/src/vm/Debugger.cpp

/home/paul/mozilla/fennec/fennec/js/src/ion/arm/Assembler-arm.h:30:33: error: both 'const' and 'constexpr' cannot be used here

(full log attached)

Using android-sdk_r20.0.3-linux (but it might be 22 since I followed the instructions here [1] to update the sdk), and android-ndk-r8e-linux-x86_64.

[1] https://wiki.mozilla.org/Mobile/Fennec/Android#Install_Android_SDK

Comment 1

[Bill Gianopoulos [:WG9s]]

Seems difficult to determine versions being used because of going to a generic non version specific path in the build config for official builds.  This just makes it harder for us to figure things out.  Please go back to the old version specific paths so developers have a clue what is going on.

Comment 2

[Bill Gianopoulos [:WG9s]]

We really need to know shat version SDK, NDK and JAVA versions current nightlies build with.  Where is this information documented?

Comment 3

[Bill Gianopoulos [:WG9s]]

Oh and GCC version.  I tried to match gcc version but that failed even worse because of not being able to determine versions of other tools because of using non version specific paths.

Comment 4

[Bill Gianopoulos [:WG9s]]

IF there are build prerequisites this needs to be tested in and diagnosed with a clear message in configure.  Just Sayin'!

Comment 5

[Bill Gianopoulos [:WG9s]]

I still think this should be a blocker.

Comment 6

[Paul Rouget [:paul]]

Apparently, this only affects people who didn't manage to build Fennec yet. Probably an issue with initial configuration.

Comment 7

[Bill Gianopoulos [:WG9s]]

IF that were the case I would never have set it as a blocker.

Comment 8

[Bill Gianopoulos [:WG9s]]

This is a new issue today.  Built just fine yesterday.

Comment 9

[Paul Rouget [:paul]]

Adding `ac_add_options --with-android-gnu-compiler-version=4.7` solved my problem.

Comment 10

[Paul Rouget [:paul]]

I've updated the documentation with a working mozconfig:
https://wiki.mozilla.org/Mobile/Fennec/Android#Setup_Fennec_mozconfig

Comment 11

[Bill Gianopoulos [:WG9s]]

Please explain in the bug what you did to resolve the issue.

Comment 12

[Paul Rouget [:paul]]

(In reply to Bill Gianopoulos [:WG9s] from comment #11)
> Please explain in the bug what you did to resolve the issue.

See comment 9.

Comment 13

[Bill Gianopoulos [:WG9s]]

Yes but that did not work for me even before his issue so still need to know what sdk and ndk and java version i need.
Please try to read my comments before replying.

Comment 14

[Paul Rouget [:paul]]

(In reply to Bill Gianopoulos [:WG9s] from comment #13)
> Yes but that did not work for me even before his issue so still need to know
> what sdk and ndk and java version i need.
> Please try to read my comments before replying.

See comment 0.

Comment 15

[Bill Gianopoulos [:WG9s]]

Interesting but still does not answer the question about what is the SDK version, NDK version and JAVA version that is used for official builds.

Comment 16

[Paul Rouget [:paul]]

(In reply to Bill Gianopoulos [:WG9s] from comment #15)
> Interesting but still does not answer the question about what is the SDK
> version, NDK version and JAVA version that is used for official builds.

This bug is not about that.

We tried to tell you on IRC. Look at the mozconfig: http://mxr.mozilla.org/mozilla-central/source/mobile/android/config/mozconfigs/android/nightly

Basically:
- gcc 4.7
- jdk 6
- sdk 16
- ndk r8e (this is not 100% sure, it's not mentioned on for x64, but from the documentation: "The automated builders currently use version r8e")

Comment 17

[Bill Gianopoulos [:WG9s]]

There is still a issue here. If android ndk r8e and gcc version 4.7 is a requirement, these should be checked for in configure and a reasonable error produced.

Comment 18

[Bill Gianopoulos [:WG9s]]

The requirement seems to be for gcc 4.7 which they current documented minimum ndk version does not even provide.

Comment 19

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.