The default bug view has changed. See this FAQ.

convert uses of nsIDocShellHistory in comm-central

RESOLVED FIXED in Thunderbird 24.0

Status

MailNews Core
Backend
--
major
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.90 KB, patch
standard8
: review+
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
I get this permanent exception when starting Thunderbird:

Error: Places database may be locked: [Exception... "Could not convert JavaScript argument arg 0 [nsISupports.QueryInterface]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://messenger/content/specialTabs.js :: specialTabs.openSpecialTabsOnStartup :: line 482"  data: no]
Source file: chrome://messenger/content/specialTabs.js
Line: 485

That is this code:
// enable global history
try {
  browser.docShell.QueryInterface(Components.interfaces.nsIDocShellHistory)
         .useGlobalHistory = true;
} catch(ex) {
  Components.utils.reportError("Places database may be locked: " + ex);
}

nsIDocShellHistory was merged into nsIDocShell in bug 882079.

There is also one occurrence in Seamonkey at http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSuiteGlue.js#200
(Assignee)

Comment 1

4 years ago
Created attachment 763113 [details] [diff] [review]
patch

The TB part was tested and no longer produces the exception. I did not test what the feature actually enables, but the conversion pattern is the same as in bug 882079.

The Seamonkey part is untested.
Attachment #763113 - Flags: review?(neil)
Attachment #763113 - Flags: review?(mbanner)

Updated

4 years ago
Attachment #763113 - Flags: review?(neil) → review+
Attachment #763113 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/5291452fffc9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in before you can comment on or make changes to this bug.