883565 - [Settings] Settings interface for SIM PIN unusable due to UI misplacement

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[:gerard-majax]

On current gaia master, the interface to enable/disable a SIM PIN code in Settings is broken, the vast majority of the UI is hidden on the left.

Comment 1

[:gerard-majax]

Attachment: Screenshot of the description screen: okay

Comment 2

[:gerard-majax]

Attachment: Screenshot of the UI for setting PIN code: not okay

Please find attached a first screenshot demonstrating the issue, just after tapping "Enable SIM PIN".

Comment 3

[:gerard-majax]

Attachment: Screenshot of the UI for setting PIN code after tapping some chars: still not okay

Please find attached a second screenshot demonstrating the issue, after tapping a PIN code. You can notice that the UI moved to the right.

Comment 4

[:gerard-majax]

I'm reproducing this with gecko master.

Comment 5

[Fabien Cazenave [:kaze]]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> I'm reproducing this with gecko master.

Do you mean that it works with the b2g18 branch, but not with the moz-central one?

Comment 6

[:gerard-majax]

(In reply to Fabien Cazenave [:kaze] from comment #5)
> (In reply to Alexandre LISSY :gerard-majax from comment #4)
> > I'm reproducing this with gecko master.
> 
> Do you mean that it works with the b2g18 branch, but not with the
> moz-central one?

Yes. My Nexus S runs gaia master on top of b2g18 and it does not exposes the issue. The Inari was running on gecko master and it exposed the issue.

Comment 7

[bhavana bajaj [:bajaj]]

Looks like 1.1 is unaffected, leo-.

Comment 8

[Anshul]

I am seeing the same issue with a build based off Moz central.

Comment 9

[Anshul]

Sorry forgot to mention that this issue would need to be fixed for upcoming 1.2 release and hence a request for koi?

Comment 10

[Anshul]

He Fabian, is there an update on this issue?

Comment 12

[Fabien Cazenave [:kaze]]

Hi Anshul, this is still hitting us with:
 • Gecko moz-central 20130826000531
 • Gaia master 5de91890 (= today’s version)

I’m busy with FDN stuff right now; Arthur, would you mind having a look or assigning it to someone?

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

George will help on this issue. Thanks George!

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch will focus on input only after panel ready.

Comment 15

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 799940 [details]
PR to master

Thanks for taking care of this. Good job! r=me.

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks Arthur.

Merge into master,
https://github.com/mozilla-b2g/gaia/commit/a23ea9dfa5345d5a7cee8bc7c57df6b60d22a09d

Comment 17

[Fabien Cazenave [:kaze]]

Nice catch, thanks!

However, the SIM PIN input dialog now opens backwards. Is that a known issue? If not, would you please open a follow-up and have a look?

Comment 18

[Fabien Cazenave [:kaze]]

Forget that: the dialog opens backwards because I attached a class name on the <section> container — so that’s another bug.

Comment 19

[Arthur Chen [:arthurcc][inactive after 6/30]]

Reopen the bug as the reproduce rate decreases but still not fixed completely.

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

As the patch provided by George addresses, the root cause is that gecko tries to move the input into the viewport when the input gets focused. We must set focus after the transition completely ends or we see this bug. Apparently 'transitionend' is not sufficient in this case.

Comment 21

[(Inactive after June) George Duan [:gduan] [:喬智]]

I am trying to find a way to reproduce it, but it's not so easy on latest mc 0925 build and latest gaia. Is there any suggestion?

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Functional issue, blocking. Should be fixed if it can be reliable reproduced.

Comment 23

[Preeti Raghunath(:Preeti)]

This should be in 1.2 as it landed on master on 9/5 per comment 16.

John,

Can you please check if this patch is in 1.2? If not, we can re-nom the same.

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Right. Unset koi?.

Arthur, per comment 19, please open another bug if the patch is not exhaust. We don't reopen a bug with landed patch without backing the code out.

Comment 25

[Arthur Chen [:arthurcc][inactive after 6/30]]

Let's file another bug if the issue can be reproduced.