Improved MIR printing

RESOLVED FIXED in mozilla25

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sunfish, Unassigned)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
I often find it desirable to be able to print out MIRGraph or MBasicBlock contents from within a debugger.
(Reporter)

Comment 1

5 years ago
Created attachment 763155 [details] [diff] [review]
a proposed fix
Attachment #763155 - Flags: review?(dvander)
(Reporter)

Comment 2

5 years ago
Created attachment 763156 [details] [diff] [review]
a supplementary patch
Attachment #763156 - Flags: review?(dvander)
As soon as this land, can you document how to use these function from the debugger on the Hacking tips page[1].

Thanks

[1] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips
Comment on attachment 763155 [details] [diff] [review]
a proposed fix

Review of attachment 763155 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the long delay here, was on PTO and didn't notice the r?
Attachment #763155 - Flags: review?(dvander) → review+
Attachment #763156 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/5ccd0b486a97
https://hg.mozilla.org/mozilla-central/rev/93622f94362c
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
(Reporter)

Comment 7

5 years ago
(In reply to Nicolas B. Pierron [:nbp] from comment #3)
> As soon as this land, can you document how to use these function from the
> debugger on the Hacking tips page[1].
> 
> Thanks
> 
> [1] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Hacking_Tips

I added a paragraph to the end of that page.
(Reporter)

Updated

5 years ago
Blocks: 891697
You need to log in before you can comment on or make changes to this bug.